Skip to content

Fix/filesystem querykey#426

Merged
matthewlouisbrockman merged 2 commits into
mainfrom
fix/filesystem-querykey
Jun 17, 2026
Merged

Fix/filesystem querykey#426
matthewlouisbrockman merged 2 commits into
mainfrom
fix/filesystem-querykey

Conversation

@matthewlouisbrockman

@matthewlouisbrockman matthewlouisbrockman commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

reload files on tab change

@cla-bot cla-bot Bot added the cla-signed label Jun 17, 2026
@vercel

vercel Bot commented Jun 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
web Ready Ready Preview, Comment Jun 17, 2026 4:03am

Request Review

@cursor

cursor Bot commented Jun 17, 2026 •
edited
Loading

Copy link
Copy Markdown

PR Summary

Low Risk
Single React Query option change in sandbox inspect; only affects when the connect/load runs on remount.

Overview
Filesystem data could stay stale when leaving the sandbox inspect view and coming back, because the sandbox-inspect-connect query used refetchOnMount: false with infinite staleTime, so remounting did not run connectSandbox again.

refetchOnMount is set to 'always' so the connect query runs on mount and reloads the sandbox connection and root directory when the tab or view is shown again.

Reviewed by Cursor Bugbot for commit 357cee3. Bugbot is set up for automated code reviews on this repo. Configure here.

ben-fornefeld
ben-fornefeld approved these changes Jun 17, 2026
View reviewed changes

@ben-fornefeld ben-fornefeld left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a bit of a smell that we should refactor the state management for this route, but we'll get to it

@matthewlouisbrockman matthewlouisbrockman merged commit a5d697a into main Jun 17, 2026
14 checks passed
@matthewlouisbrockman matthewlouisbrockman deleted the fix/filesystem-querykey branch June 17, 2026 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ben-fornefeld ben-fornefeld ben-fornefeld approved these changes
@drankou drankou Awaiting requested review from drankou drankou is a code owner
@huv1k huv1k Awaiting requested review from huv1k huv1k is a code owner

Assignees

No one assigned

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@matthewlouisbrockman @ben-fornefeld