Skip to content

Switch dashboard terminal to Ghostty#433

Closed
matthewlouisbrockman wants to merge 6 commits into
mainfrom
terminal-ghossty
Closed

Switch dashboard terminal to Ghostty#433
matthewlouisbrockman wants to merge 6 commits into
mainfrom
terminal-ghossty

Conversation

@matthewlouisbrockman

@matthewlouisbrockman matthewlouisbrockman commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

switches ghostty for xterm; opencode template looks better on it

downside: no mouse, but that's ok. mice are silly.

@cursor

cursor Bot commented Jun 17, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Core terminal UX and PTY resize behavior change with a new WASM/async dependency; paste sanitization affects what reaches the shell.

Overview
Replaces @xterm/xterm with ghostty-web (and strip-ansi) for the dashboard sandbox terminal. use-terminal-instance now async-loads Ghostty, uses FitAddon for layout, and shows a plain-text message if init fails.

PTY sizing in terminal-size uses the emulator’s cols/rows when present instead of measuring xterm DOM cells. terminal-paste sanitizes clipboard text (ANSI and control chars stripped); paste is handled on the terminal panel via onPasteCapture and forwarded to the PTY.

Unit tests cover the new sizing behavior and sanitizeTerminalPaste.

Reviewed by Cursor Bugbot for commit 392ddd7. Bugbot is set up for automated code reviews on this repo. Configure here.

@vercel

vercel Bot commented Jun 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
web Ready Ready Preview, Comment Jun 18, 2026 12:50am

Request Review

Comment thread src/features/dashboard/terminal/use-terminal-instance.ts
Comment thread src/features/dashboard/terminal/use-terminal-instance.ts Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6eecc9b5aa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/features/dashboard/terminal/use-terminal-instance.ts Outdated
Comment thread package.json
Comment thread src/features/dashboard/terminal/terminal-size.ts Outdated
Comment thread src/features/dashboard/terminal/use-terminal-instance.ts

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8acce2d. Configure here.

Comment thread src/features/dashboard/terminal/terminal-size.ts
@matthewlouisbrockman

Copy link
Copy Markdown
Contributor Author

don't need this anymore, fixed with webgl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant