Xterm sizing adjustments

[matthewlouisbrockman]

better size handling for canvas display

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
web	Ready	Preview, Comment	Jun 18, 2026 10:06pm

[cursor]

PR Summary

Low Risk
Changes are confined to dashboard terminal UI sizing and lifecycle; no auth or data paths, with minor row-count behavior change from removed row fudge.

Overview
Removes the @xterm/addon-fit dependency and stops using FitAddon; resize now goes through calculateTerminalSize and only calls xterm/PTY resize when dimensions change or { force: true }.

terminal-size.ts reads xterm renderer CSS cell dimensions (for canvas/WebGL), adds helper-textarea height as a fallback, and drops the extra -1 row when computing rows, which shifts expected col/row counts in tests.

use-terminal-instance.ts loads WebGL then canvas renderers via dynamic import, resizes after the renderer attaches, guards async work on unmount, and wraps scrollToBottom in try/catch.

dashboard-terminal.tsx swallows failed PTY resize promises, forces resize after PTY attach and bfcache restore, and moves pagehide/pageshow/unmount cleanup into useEffectEvent so the listener effect has an empty dependency array.

^{Reviewed by Cursor Bugbot for commit 75e691b. Bugbot is set up for automated code reviews on this repo. Configure here.}

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4e01ff0282

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit e49f81f. Configure here.}