Skip to content

Make dashboard terminal team scoped#440

Open
matthewlouisbrockman wants to merge 16 commits into
mainfrom
make-teamterminal-instead-of-just-dashboardterminal-eng-4336
Open

Make dashboard terminal team scoped#440
matthewlouisbrockman wants to merge 16 commits into
mainfrom
make-teamterminal-instead-of-just-dashboardterminal-eng-4336

Conversation

@matthewlouisbrockman

@matthewlouisbrockman matthewlouisbrockman commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

moves the page stuff from /dashboard/terminal to /dashboard//terminal; autoredirecfs when sent there

@linear-code

linear-code Bot commented Jun 18, 2026

Copy link
Copy Markdown

ENG-4336

@vercel

vercel Bot commented Jun 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
web Ready Ready Preview, Comment Jun 19, 2026 2:02am

Request Review

@cursor

cursor Bot commented Jun 18, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Routing and auth gating changed for terminal URLs, and sandbox access no longer falls back to other teams.

Overview
The dashboard terminal lives at /dashboard/{teamSlug}/terminal instead of a global /dashboard/terminal path. /dashboard/terminal now redirects to /dashboard?tab=terminal, and the dashboard entry route forwards template, sandboxId, and command onto the resolved team terminal URL.

The team terminal page reads teamSlug from the route, resolves that team from the user’s teams, and looks up a sandbox only in that team (the old cross-team resolveTerminalSandbox / preferred-team scan is removed). Sign-in returnTo targets the team terminal and can include command. Unauthenticated dashboard visits (including terminal) go to sign-in with returnTo preserving path and query; the terminal-only auth bypass is removed.

Reviewed by Cursor Bugbot for commit 103c668. Bugbot is set up for automated code reviews on this repo. Configure here.

Comment thread src/app/dashboard/terminal/page.tsx Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8540954569

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/app/dashboard/[teamSlug]/terminal/page.tsx Outdated
Comment thread src/app/dashboard/terminal/page.tsx Outdated
Comment thread src/app/dashboard/terminal/route.ts Outdated
Comment thread src/configs/urls.ts Outdated
Comment thread src/core/server/proxy/handlers.ts Outdated
Comment thread src/core/server/proxy/handlers.ts
…tead-of-just-dashboardterminal-eng-4336

# Conflicts:
#	src/app/dashboard/terminal/page.tsx
#	src/configs/layout.ts
Comment thread src/app/dashboard/[teamSlug]/terminal/page.tsx
Comment thread src/app/dashboard/route.ts Outdated
Comment thread src/app/dashboard/terminal/route.ts Outdated
Comment thread src/app/dashboard/terminal/route.ts

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 9af0263. Configure here.

Comment thread src/app/dashboard/route.ts
…t-dashboardterminal-eng-4336' into make-teamterminal-instead-of-just-dashboardterminal-eng-4336

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we never referenced this url anywhere, let's remove it 🙏🏼

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

o, u want to yeet /dashboard/terminal? that works, can see if can move it to /embed/terminal instead although in that case maybe can stick it in another repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants