Skip to content

[ENG-4352] Allow public templates in dashboard terminal#462

Closed
matthewlouisbrockman wants to merge 1 commit into
mainfrom
overly-restrictive-template-checks-on-dashboardtabterminal-eng-4352
Closed

[ENG-4352] Allow public templates in dashboard terminal#462
matthewlouisbrockman wants to merge 1 commit into
mainfrom
overly-restrictive-template-checks-on-dashboardtabterminal-eng-4352

Conversation

@matthewlouisbrockman

Copy link
Copy Markdown
Contributor

What changed

  • Allows owner/template references through the dashboard terminal template preflight.
  • Keeps local/default template availability checks for bare template names.
  • Adds unit coverage for public template reference detection.

Why

/sbx/new?template=owner/template worked because it calls Sandbox.create(template) directly. The dashboard terminal page rejected the same public template reference before launch because it only checked default templates and templates owned by the current team.

This made public workshop links like aiengineer-d56d/aiengineer-guide show as unavailable in the terminal UI even though the SDK could create them.

Validation

  • bunx vitest run tests/unit/dashboard-terminal.test.ts
  • bunx biome check 'src/app/dashboard/[teamSlug]/terminal/page.tsx' src/features/dashboard/terminal/template.ts tests/unit/dashboard-terminal.test.ts

@linear-code

linear-code Bot commented Jun 24, 2026

Copy link
Copy Markdown

ENG-4352

@cla-bot cla-bot Bot added the cla-signed label Jun 24, 2026
@vercel

vercel Bot commented Jun 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
web Ready Ready Preview, Comment Jun 24, 2026 9:35pm
web-tango Ready Ready Preview, Comment Jun 24, 2026 9:35pm

Request Review

@cursor

cursor Bot commented Jun 24, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Small preflight bypass for a string shape only; launch still depends on the same sandbox create path as before.

Overview
The dashboard terminal page used to mark owner/template query values unavailable when they were not in the signed-in team’s default or team template lists, even though sandbox creation already accepted those public references.

This change adds isPublicTemplateReference (exactly one /, both segments non-empty) and returns available from isTerminalTemplateAvailable for those strings without calling the template repositories. Bare names like base or python_3.12-dev still go through the existing list check. Unit tests cover the helper’s true/false cases.

Reviewed by Cursor Bugbot for commit bab3cf6. Bugbot is set up for automated code reviews on this repo. Configure here.

@matthewlouisbrockman

Copy link
Copy Markdown
Contributor Author

Closing because Codex should not create pull requests in this workflow. The branch remains pushed for a human to open if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant