From 4880038d72ec2bf6f068743fbec4281e5b8d9de5 Mon Sep 17 00:00:00 2001 From: Ben Fornefeld Date: Tue, 24 Jun 2025 21:32:09 +0200 Subject: [PATCH 1/3] fix: use correct response status code from infra oapi client --- src/server/keys/get-api-keys.ts | 4 ++-- src/server/sandboxes/get-sandbox-details.ts | 12 +++++++++--- src/server/sandboxes/get-team-sandboxes.ts | 4 ++-- src/server/templates/get-team-templates.ts | 4 ++-- src/server/templates/templates-actions.ts | 13 ++++++++++--- 5 files changed, 25 insertions(+), 12 deletions(-) diff --git a/src/server/keys/get-api-keys.ts b/src/server/keys/get-api-keys.ts index 15cf75039..6864a1a5d 100644 --- a/src/server/keys/get-api-keys.ts +++ b/src/server/keys/get-api-keys.ts @@ -28,8 +28,8 @@ export const getTeamApiKeys = authActionClient }) if (res.error) { - const status = res.error?.code ?? 500 - logError(ERROR_CODES.INFRA, '/api-keys', res.error) + const status = res.response.status + logError(ERROR_CODES.INFRA, '/api-keys', res.error, res.data) return handleDefaultInfraError(status) } diff --git a/src/server/sandboxes/get-sandbox-details.ts b/src/server/sandboxes/get-sandbox-details.ts index 8be8440dd..c551ad3b5 100644 --- a/src/server/sandboxes/get-sandbox-details.ts +++ b/src/server/sandboxes/get-sandbox-details.ts @@ -30,9 +30,15 @@ export const getSandboxDetails = authActionClient }) if (res.error) { - const status = res.error?.code ?? 500 - - logError(ERROR_CODES.INFRA, '/sandboxes/{sandboxID}', res.error, res.data) + const status = res.response.status + + logError( + ERROR_CODES.INFRA, + '/sandboxes/{sandboxID}', + status, + res.error, + res.data + ) if (status === 404) { return returnServerError( diff --git a/src/server/sandboxes/get-team-sandboxes.ts b/src/server/sandboxes/get-team-sandboxes.ts index 098699fad..67ab2f20e 100644 --- a/src/server/sandboxes/get-team-sandboxes.ts +++ b/src/server/sandboxes/get-team-sandboxes.ts @@ -39,9 +39,9 @@ export const getTeamSandboxes = authActionClient }) if (res.error) { - const status = res.error?.code ?? 500 + const status = res.response.status - logError(ERROR_CODES.INFRA, '/sandboxes', res.error, res.data) + logError(ERROR_CODES.INFRA, '/sandboxes', status, res.error, res.data) return handleDefaultInfraError(status) } diff --git a/src/server/templates/get-team-templates.ts b/src/server/templates/get-team-templates.ts index 0eed0083a..0cbfc6e36 100644 --- a/src/server/templates/get-team-templates.ts +++ b/src/server/templates/get-team-templates.ts @@ -44,8 +44,8 @@ export const getTeamTemplates = authActionClient }) if (res.error) { - const status = res.error?.code ?? 500 - logError(ERROR_CODES.INFRA, '/templates', res.error, res.data) + const status = res.response.status + logError(ERROR_CODES.INFRA, '/templates', status, res.error, res.data) return handleDefaultInfraError(status) } diff --git a/src/server/templates/templates-actions.ts b/src/server/templates/templates-actions.ts index 18ac83018..8f92a8084 100644 --- a/src/server/templates/templates-actions.ts +++ b/src/server/templates/templates-actions.ts @@ -31,10 +31,11 @@ export const deleteTemplateAction = authActionClient }) if (res.error) { - const status = res.error?.code ?? 500 + const status = res.response.status logError( ERROR_CODES.INFRA, '/templates/{templateID}', + status, res.error, res.data ) @@ -91,8 +92,14 @@ export const updateTemplateAction = authActionClient }) if (res.error) { - const status = res.error?.code ?? 500 - logError(ERROR_CODES.INFRA, '/templates/{templateID}', res.error) + const status = res.response.status + logError( + ERROR_CODES.INFRA, + '/templates/{templateID}', + status, + res.error, + res.data + ) if (status === 404) { return returnServerError('Template not found') From 2af79d711e5dc4043708359d94e8dabfd08212b8 Mon Sep 17 00:00:00 2001 From: Ben Fornefeld Date: Tue, 24 Jun 2025 21:35:36 +0200 Subject: [PATCH 2/3] add: status code to generateAccessToken infra api invocation error logging --- src/lib/utils/server.ts | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/lib/utils/server.ts b/src/lib/utils/server.ts index 345b9ad54..4aca4ab6a 100644 --- a/src/lib/utils/server.ts +++ b/src/lib/utils/server.ts @@ -63,7 +63,13 @@ export async function generateE2BUserAccessToken(supabaseAccessToken: string) { }) if (res.error) { - logError(ERROR_CODES.INFRA, '/access-tokens', res.error, res.data) + logError( + ERROR_CODES.INFRA, + '/access-tokens', + res.response.status, + res.error, + res.data + ) return returnServerError(`Failed to generate e2b user access token`) } From f2c47c163501d7ebdb963d4ec68e22e9db5f762c Mon Sep 17 00:00:00 2001 From: Ben Fornefeld Date: Tue, 24 Jun 2025 21:37:12 +0200 Subject: [PATCH 3/3] add: pass status code to api-keys get error logging --- src/server/keys/get-api-keys.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/server/keys/get-api-keys.ts b/src/server/keys/get-api-keys.ts index 6864a1a5d..349266669 100644 --- a/src/server/keys/get-api-keys.ts +++ b/src/server/keys/get-api-keys.ts @@ -29,7 +29,7 @@ export const getTeamApiKeys = authActionClient if (res.error) { const status = res.response.status - logError(ERROR_CODES.INFRA, '/api-keys', res.error, res.data) + logError(ERROR_CODES.INFRA, '/api-keys', status, res.error, res.data) return handleDefaultInfraError(status) }