Skip to content

Feat: Custom OTP PKCE flow + Improve error logging in authentication flow & handle supabase rate-limit error #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ben-fornefeld merged 15 commits into from
Jul 6, 2025
Merged

Feat: Custom OTP PKCE flow + Improve error logging in authentication flow & handle supabase rate-limit error #89

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
6477b3b
Refactor: Improve error logging in authentication flow
ben-fornefeld Jul 3, 2025
0335a02
wip: PKCE
ben-fornefeld Jul 4, 2025
5823dac
Refactor: Enhance authentication flow with improved redirect handling
ben-fornefeld Jul 4, 2025
5fba558
Refactor: Enhance redirect handling in authentication confirmation route
ben-fornefeld Jul 5, 2025
be2549e
Refactor: Improve OTP verification error handling in authentication c…
ben-fornefeld Jul 6, 2025
c0a0dc0
Fix password-reset rate-limit UX & add robust email-confirm route (#91)
ben-fornefeld Jul 6, 2025
d26c08b
Refactor: Enhance authentication confirmation route with improved par…
ben-fornefeld Jul 6, 2025
68ae450
Refactor: Enhance parameter validation and error handling in authenti…
ben-fornefeld Jul 6, 2025
a0abb27
Refactor: Remove unused import in authentication confirmation route &…
ben-fornefeld Jul 6, 2025
0c7f708
Refactor: Enhance authentication callback and action logging
ben-fornefeld Jul 6, 2025
9542b7d
Chore: remove unecessary condition handling
ben-fornefeld Jul 6, 2025
84fd3af
Chore: improve logs
ben-fornefeld Jul 6, 2025
6522680
Refactor: Update Supabase client creation in authentication confirmat…
ben-fornefeld Jul 6, 2025
9daec69
chore: replace unused supabase browser client
ben-fornefeld Jul 6, 2025
b9e7299
docs: Update README with email template configuration instructions fo…
ben-fornefeld Jul 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/app/api/auth/callback/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { createClient } from '@/lib/clients/supabase/server'
import { redirect } from 'next/navigation'
import { AUTH_URLS, PROTECTED_URLS } from '@/configs/urls'
import { logError, logInfo } from '@/lib/clients/logger'
import { PROTECTED_URLS } from '@/configs/urls'
import { logInfo } from '@/lib/clients/logger'
import { ERROR_CODES } from '@/configs/logs'

export async function GET(request: Request) {
Expand All @@ -26,7 +26,7 @@ export async function GET(request: Request) {
const { data, error } = await supabase.auth.exchangeCodeForSession(code)

if (error) {
logError(
console.error(
Copy link
Copy Markdown
Member

@mishushakov mishushakov Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why change from logError > console.error?

Copy link
Copy Markdown
Member Author

@ben-fornefeld ben-fornefeld Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the logger is nice when the args do not include a class instance (error in this case). i am about to fix this but in another pr.

ERROR_CODES.SUPABASE,
'Error exchanging code for session:',
error
Expand Down
8 changes: 8 additions & 0 deletions src/server/auth/auth-actions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import {
shouldWarnAboutAlternateEmail,
validateEmail,
} from '@/server/auth/validate-email'
import { ERROR_CODES } from '@/configs/logs'

export const signInWithOAuthAction = actionClient
.schema(
Expand Down Expand Up @@ -171,6 +172,13 @@ export const forgotPasswordAction = actionClient
})

if (error) {
console.error(ERROR_CODES.SUPABASE, 'Error resetting password:', error)
if (error.message.includes('security purposes')) {
return returnServerError(
Copy link
Copy Markdown
Member

@mishushakov mishushakov Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you need to return here? returnServerError throws

Copy link
Copy Markdown
Member Author

@ben-fornefeld ben-fornefeld Jul 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, it's just a convenient wrapper i am using because next-safe-action also has returnValidationError().
returnServerError actually also just throws under the hood since this is the way the actionClient is configured

'Please wait before requesting another password reset'
)
}

throw error
}
})
Expand Down