Set desktop background using custom sandbox template (#57)

* Organize and simplify Dockerfile

* Fix missing command

* Remove unnecessary sudo

* Set desktop background using custom sandbox template instead of at runtime

Author: jamesmurdza

packages/js-sdk/src/sandbox.ts

@@ -115,10 +115,6 @@ export class Sandbox extends SandboxBase {
   private lastXfce4Pid: number | null = null;
   readonly display: string;
   readonly stream: VNCServer;
-  private readonly changeWallpaperCmd: string = (
-    `xfconf-query --create -t string -c xfce4-desktop -p ` +
-    `/backdrop/screen0/monitorscreen/workspace0/last-image -s /usr/share/backgrounds/xfce/wallpaper.png`
-  )
 
   /**
    * Use {@link Sandbox.create} to create a new Sandbox instead.
@@ -264,7 +260,6 @@ export class Sandbox extends SandboxBase {
         "startxfce4", { envs: { DISPLAY: this.display }, background: true }
       );
       this.lastXfce4Pid = result.pid;
-      await this.commands.run(this.changeWallpaperCmd, { envs: { DISPLAY: this.display } });
     }
   }
 

packages/python-sdk/e2b_desktop/main.py

@@ -171,10 +171,6 @@ def stop(self) -> None:
 
 class Sandbox(SandboxBase):
     default_template = "desktop"
-    change_wallpaper_cmd = (
-        "xfconf-query --create -t string -c xfce4-desktop -p "
-        "/backdrop/screen0/monitorscreen/workspace0/last-image -s /usr/share/backgrounds/xfce/wallpaper.png"
-    )
 
     def __init__(
         self,
@@ -272,7 +268,6 @@ def _start_xfce4(self):
             self._last_xfce4_pid = self.commands.run(
                 "startxfce4", envs={"DISPLAY": self._display}, background=True
             ).pid
-            self.commands.run(self.change_wallpaper_cmd, envs={"DISPLAY": self._display})
 
     @property
     def stream(self) -> _VNCServer:

template/e2b.Dockerfile

@@ -49,7 +49,7 @@ RUN \
 # ~ Make your changes to this template BELOW this line ~
 
 # Set the default terminal
-RUN sudo ln -sf /usr/bin/xfce4-terminal.wrapper /etc/alternatives/x-terminal-emulator
+RUN ln -sf /usr/bin/xfce4-terminal.wrapper /etc/alternatives/x-terminal-emulator
 
 # Install standard apps
 RUN apt-get install -y x11-apps \
@@ -77,4 +77,6 @@ RUN mkdir -p /home/user/.config/Code/User
 COPY ./settings.json /home/user/.config/Code/User/settings.json
 
 # Copy desktop background for XFCE
-COPY ./wallpaper.png /usr/share/backgrounds/xfce/wallpaper.png
+COPY ./wallpaper.png /usr/share/backgrounds/xfce/wallpaper.png
+RUN mkdir -p /home/user/.config/xfce4/xfconf/xfce-perchannel-xml/
+COPY ./xfce4-desktop.xml /home/user/.config/xfce4/xfconf/xfce-perchannel-xml/xfce4-desktop.xml

template/xfce4-desktop.xml

@@ -0,0 +1,16 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<channel name="xfce4-desktop" version="1.0">
+    <property name="backdrop" type="empty">
+        <property name="screen0" type="empty">
+            <property name="monitorscreen" type="empty">
+                <property name="workspace0" type="empty">
+                    <property name="last-image" type="string"
+                        value="/usr/share/backgrounds/xfce/wallpaper.png" />
+                    <property name="color-style" type="int" value="0" />
+                    <property name="image-style" type="int" value="5" />
+                </property>
+            </property>
+        </property>
+    </property>
+</channel>