Skip to content

Fixes keyboard write when dashes are included #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mishushakov merged 2 commits into from
Sep 18, 2025
Merged

Fixes keyboard write when dashes are included #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ebebb1
use minus minus to stop option parsing
mishushakov Sep 18, 2025
cbb37da
added changeset
mishushakov Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/solid-ants-type.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@e2b/desktop-python': patch
'@e2b/desktop': patch
---

Uses minus minus in xdotool call to prevent parsing text as flag
4 changes: 3 additions & 1 deletion packages/js-sdk/src/sandbox.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,7 +509,9 @@ export class Sandbox extends SandboxBase {

for (const chunk of chunks) {
await this.commands.run(
`xdotool type --delay ${options.delayInMs} ${this.quoteString(chunk)}`
`xdotool type --delay ${options.delayInMs} -- ${this.quoteString(
chunk
)}`
)
}
}
Expand Down
2 changes: 1 addition & 1 deletion packages/python-sdk/e2b_desktop/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,7 +543,7 @@ def break_into_chunks(text: str, n: int):

for chunk in break_into_chunks(text, chunk_size):
self.commands.run(
f"xdotool type --delay {delay_in_ms} {quote_string(chunk)}"
f"xdotool type --delay {delay_in_ms} -- {quote_string(chunk)}"
)

def press(self, key: Union[str, list[str]]):
Expand Down