Upload as an job artifact (#2)

* Save as an artifact while developing

* Simplify

Author: jakubno

.github/workflows/fc-kernels.yml

@@ -23,21 +23,19 @@ jobs:
       - name: Build kernels
         run: sudo make build
 
-      - name: Set bucket based on branch
-        id: set-bucket
-        run: |
-          if [ "${{ github.ref_name }}" = "main" ]; then
-            echo "DESTINATION=${{ vars.GCP_BUCKET_NAME }}/kernels" >> $GITHUB_OUTPUT
-          else
-            echo "DESTINATION=${{ vars.GCP_DEV_BUCKET_NAME }}/${{ github.ref_name }}" >> $GITHUB_OUTPUT
-            echo "You can copy the built kernels by running the following command in your infra repo:"
-            echo "gsutil cp -r builds gs://${{ vars.GCP_DEV_BUCKET_NAME }}/${{ github.ref_name }}/* gs://$(GCP_PROJECT_ID)-fc-kernels/"
-          fi
-
       - name: Upload kernels
+        if: github.ref_name == 'main'
         uses: "google-github-actions/upload-cloud-storage@v1"
         with:
           path: "./builds"
-          destination: ${{ steps.set-bucket.outputs.DESTINATION }}/kernels
+          destination: ${{ vars.GCP_BUCKET_NAME }}/kernels
           gzip: false
           parent: false
+
+      - name: Upload kernels as artifact
+        if: github.ref_name != 'main'
+        uses: actions/upload-artifact@v4
+        with:
+          name: kernels-${{ github.run_id }}
+          path: ./builds
+          retention-days: 7

README.md

@@ -22,6 +22,9 @@ This project automates the building of custom Linux kernels for Firecracker micr
    ```
    The built kernels will be placed in `builds/vmlinux-<version>/vmlinux.bin`.
 
+## Development Workflow
+  - On every push, GitHub Actions will automatically build the kernels and save it as an artifact.
+
 ## License
 
 This project is licensed under the Apache License 2.0. See [LICENSE](LICENSE) for details. 

terraform/.env.template

@@ -1,4 +1,3 @@
 GCP_PROJECT_ID=
 PREFIX=
-TERRAFORM_STATE_BUCKET=
-GCP_REGION=
+TERRAFORM_STATE_BUCKET=

terraform/Makefile

@@ -2,8 +2,7 @@
 
 tf_vars := TF_VAR_gcp_project_id=$(GCP_PROJECT_ID) \
 	TF_VAR_prefix=$(PREFIX) \
-	TF_VAR_terraform_state_bucket=$(TERRAFORM_STATE_BUCKET) \
-	TF_VAR_gcp_region=$(GCP_REGION) \
+	TF_VAR_terraform_state_bucket=$(TERRAFORM_STATE_BUCKET)
 
 
 .PHONY: init

terraform/main.tf

@@ -68,26 +68,6 @@ resource "google_storage_bucket_iam_member" "fc_kernels_bucket_iam" {
   member = "serviceAccount:${google_service_account.fc_kernels.email}"
 }
 
-resource "google_storage_bucket" "development_bucket" {
-  location = var.gcp_region
-  name     = "${var.gcp_project_id}-fc-kernels-development"
-}
-
-resource "google_storage_bucket_iam_binding" "org_read_access" {
-  bucket = google_storage_bucket.development_bucket.name
-  role   = "roles/storage.objectViewer"
-
-  members = [
-    "domain:e2b.dev"
-  ]
-}
-
-resource "google_storage_bucket_iam_member" "fc_kernels_development_bucket_iam" {
-  bucket = google_storage_bucket.development_bucket.name
-  role   = "roles/storage.objectUser"
-  member = "serviceAccount:${google_service_account.fc_kernels.email}"
-}
-
 resource "google_service_account_iam_member" "gha_service_account_wif_tokencreator_iam_member" {
   service_account_id = google_service_account.fc_kernels.name
   role               = "roles/iam.workloadIdentityUser"
@@ -122,10 +102,3 @@ resource "github_actions_variable" "gcs_bucket_name" {
   value         = var.gcs_bucket_name
   variable_name = "GCP_BUCKET_NAME"
 }
-
-resource "github_actions_variable" "gcs_dev_bucket_name" {
-  repository    = var.github_repository
-  variable_name = "GCP_DEV_BUCKET_NAME"
-  value         = google_storage_bucket.development_bucket.name
-}
-

terraform/variables.tf

@@ -8,10 +8,6 @@ variable "github_repository" {
   default = "fc-kernels"
 }
 
-variable "gcp_region" {
-  type = string
-}
-
 variable "gcp_project_id" {
   description = "The project to deploy the cluster in"
   type        = string