Skip to content

Fix and clean up get_tag tag lookup #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arkamar merged 2 commits into from
Mar 24, 2026
Merged

Fix and clean up get_tag tag lookup #16

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a54967
fix: quote grep patterns in get_tag to match version delimiter correctly
arkamar Mar 24, 2026
c4b33b5
refactor: use braces instead of subshell in get_tag
arkamar Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,13 @@ function install_dependencies {

# prints the git tag corresponding to the newest and best matching the provided kernel version $1
function get_tag {
local KERNEL_VERSION=$1
local KERNEL_VERSION="${1}"

# list all tags from newest to oldest
(git --no-pager tag -l --sort=-creatordate | grep microvm-kernel-$KERNEL_VERSION\..*\.amzn2 \
|| git --no-pager tag -l --sort=-creatordate | grep kernel-$KERNEL_VERSION\..*\.amzn2) | head -n1
{
git --no-pager tag -l --sort=-creatordate | grep "microvm-kernel-${KERNEL_VERSION}-.*\.amzn2" \
|| git --no-pager tag -l --sort=-creatordate | grep "kernel-${KERNEL_VERSION}-.*\.amzn2"
} | head -n1
}

function build_version {
Expand Down
Loading