Skip to content

refactor: use _hash instead of -hash in GCS path #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ValentaTomas wants to merge 1 commit into from
Closed

refactor: use _hash instead of -hash in GCS path #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ Release asset naming for that commit:
vmlinux-<version>.bin # legacy (= amd64) for backwards compat
```

4. The arch-specific binaries are uploaded to each deploy environment's GCS bucket at `gs://$GCP_BUCKET_NAME/kernels/vmlinux-<version>-<short_hash>/<arch>/vmlinux.bin`. Deploy environments: `staging`, `juliett`, `foxtrot`. To upload an existing release to a bucket manually, run `./scripts/upload-release-to-gcs.sh --hash <commit_hash> --bucket <bucket>/kernels` (add `--dry-run` to preview). Existing objects are never overwritten.
4. The arch-specific binaries are uploaded to each deploy environment's GCS bucket at `gs://$GCP_BUCKET_NAME/kernels/vmlinux-<version>_<short_hash>/<arch>/vmlinux.bin`. Deploy environments: `staging`, `juliett`, `foxtrot`. To upload an existing release to a bucket manually, run `./scripts/upload-release-to-gcs.sh --hash <commit_hash> --bucket <bucket>/kernels` (add `--dry-run` to preview). Existing objects are never overwritten.

## New kernel in E2B's infra
_Note: these steps should give you a new kernel on your self-hosted E2B using https://github.com/e2b-dev/infra_
Expand Down
4 changes: 2 additions & 2 deletions scripts/upload-release-to-gcs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/usr/bin/env bash
# Uploads vmlinux-*-{amd64,arm64}.bin assets from a fc-kernels GitHub release
# to GCS at:
# gs://<bucket>/vmlinux-<version>-<short_hash>/<arch>/vmlinux.bin
# gs://<bucket>/vmlinux-<version>_<short_hash>/<arch>/vmlinux.bin
#
# Existing objects are never overwritten. The legacy non-arch release asset
# (vmlinux-<version>.bin) is intentionally skipped — under a fresh
Expand Down Expand Up @@ -93,7 +93,7 @@ for asset in "${ASSETS[@]}"; do
fi
version="${BASH_REMATCH[1]}"
arch="${BASH_REMATCH[2]}"
dst="${BUCKET_URI}/vmlinux-${version}-${SHORT_HASH}/${arch}/vmlinux.bin"
dst="${BUCKET_URI}/vmlinux-${version}_${SHORT_HASH}/${arch}/vmlinux.bin"

if gcloud storage ls "$dst" >/dev/null 2>&1; then
echo " EXISTS $dst"
Expand Down
Loading