Skip to content

Commit 1e3a52b

Browse files
committed
remove registry from tag
1 parent 4c1a177 commit 1e3a52b

3 files changed

Lines changed: 23 additions & 2 deletions

File tree

packages/shared/pkg/dockerhub/repository.go

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import (
55
"fmt"
66
"time"
77

8+
"github.com/google/go-containerregistry/pkg/name"
89
containerregistry "github.com/google/go-containerregistry/pkg/v1"
910

1011
"github.com/e2b-dev/infra/packages/shared/pkg/env"
@@ -49,3 +50,13 @@ func GetRemoteRepository(ctx context.Context) (RemoteRepository, error) {
4950

5051
return nil, fmt.Errorf("unknown dockerhub remote repository provider: %s", provider)
5152
}
53+
54+
func removeRegistryFromTag(tag string) (string, error) {
55+
ref, err := name.ParseReference(tag)
56+
if err != nil {
57+
return "", fmt.Errorf("invalid image reference: %w", err)
58+
}
59+
refWithoutRegistry := ref.String()
60+
61+
return refWithoutRegistry, nil
62+
}

packages/shared/pkg/dockerhub/repository_aws.go

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,12 @@ func NewAWSRemoteRepository(ctx context.Context, repositoryURL string) (*AWSRemo
3434
}
3535

3636
func (g *AWSRemoteRepository) GetImage(ctx context.Context, tag string, platform containerregistry.Platform) (containerregistry.Image, error) {
37-
ref, err := name.ParseReference(g.repositoryURL + "/" + tag)
37+
tagWithoutRegistry, err := removeRegistryFromTag(tag)
38+
if err != nil {
39+
return nil, fmt.Errorf("error removing registry from tag: %w", err)
40+
}
41+
42+
ref, err := name.ParseReference(g.repositoryURL + "/" + tagWithoutRegistry)
3843
if err != nil {
3944
return nil, fmt.Errorf("invalid image reference: %w", err)
4045
}

packages/shared/pkg/dockerhub/repository_gcp.go

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,12 @@ func NewGCPRemoteRepository(ctx context.Context, repositoryURL string) (*GCPRemo
3535
}
3636

3737
func (g *GCPRemoteRepository) GetImage(ctx context.Context, tag string, platform containerregistry.Platform) (containerregistry.Image, error) {
38-
ref, err := name.ParseReference(g.repositoryURL + "/" + tag)
38+
tagWithoutRegistry, err := removeRegistryFromTag(tag)
39+
if err != nil {
40+
return nil, fmt.Errorf("error removing registry from tag: %w", err)
41+
}
42+
43+
ref, err := name.ParseReference(g.repositoryURL + "/" + tagWithoutRegistry)
3944
if err != nil {
4045
return nil, fmt.Errorf("invalid image reference: %w", err)
4146
}

0 commit comments

Comments
 (0)