perf(atomicbitset): use CardinalityInRange via e2b-dev/roaring fork

Switch HasRange from Rank() to CardinalityInRange() which is O(k) in
containers spanned rather than O(C) in total containers.

Use e2b-dev/roaring fork that fixes an off-by-one in
runContainer16.getCardinalityInRange for gaps between runs within a
single container (upstream PR RoaringBitmap/roaring#521).

Also: init dirty bitset in zero-size Cache path, fix stale comment
in streaming_chunk.go.

Author: ValentaTomas

packages/orchestrator/go.mod

@@ -13,6 +13,8 @@ tool github.com/oapi-codegen/oapi-codegen/v2/cmd/oapi-codegen
 
 tool github.com/vektra/mockery/v3
 
+replace github.com/RoaringBitmap/roaring/v2 => github.com/e2b-dev/roaring/v2 v2.16.1-0.20260410073213-00ee8aef09f9
+
 require (
 	cloud.google.com/go/storage v1.59.2
 	connectrpc.com/connect v1.18.1

packages/orchestrator/go.sum

@@ -72,6 +72,7 @@ func NewCache(size, blockSize int64, filePath string, dirtyFile bool) (*Cache, e
 			size:      size,
 			blockSize: blockSize,
 			dirtyFile: dirtyFile,
+			dirty:     atomicbitset.New(),
 		}, nil
 	}
 

packages/orchestrator/pkg/sandbox/block/cache.go

@@ -271,8 +271,8 @@ func (c *StreamingChunker) Slice(ctx context.Context, off, length int64) ([]byte
 	}
 
 	// Use sliceDirect (no isCached check) since the waiter mechanism guarantees data is in the mmap.
-	// With coarse dirty granularity, isCached may return false during an active fetch even though
-	// the requested bytes have been written to the mmap.
+	// setIsCached is called once per chunk after fetch completes, so isCached may return false
+	// for bytes already written during an active fetch.
 	b, cacheErr := c.cache.sliceDirect(off, length)
 	if cacheErr != nil {
 		timer.RecordRaw(ctx, length, chunkerAttrs.failLocalReadAgain)

packages/orchestrator/pkg/sandbox/block/streaming_chunk.go

@@ -4,6 +4,8 @@ go 1.25.4
 
 tool github.com/go-swagger/go-swagger/cmd/swagger
 
+replace github.com/RoaringBitmap/roaring/v2 => github.com/e2b-dev/roaring/v2 v2.16.1-0.20260410073213-00ee8aef09f9
+
 require (
 	cloud.google.com/go/artifactregistry v1.17.1
 	cloud.google.com/go/storage v1.59.2

packages/shared/go.mod

@@ -29,17 +29,7 @@ func (b *Bitset) HasRange(start, end uint) bool {
 	b.mu.RLock()
 	defer b.mu.RUnlock()
 
-	if start >= end {
-		return true
-	}
-
-	rankEnd := b.bm.Rank(uint32(end - 1))
-	var rankBefore uint64
-	if start > 0 {
-		rankBefore = b.bm.Rank(uint32(start - 1))
-	}
-
-	return rankEnd-rankBefore == uint64(end-start)
+	return b.bm.CardinalityInRange(uint64(start), uint64(end)) == uint64(end-start)
 }
 
 func (b *Bitset) SetRange(start, end uint) {

packages/shared/go.sum

@@ -107,24 +107,19 @@ func TestHasRange_GapBetweenRanges(t *testing.T) {
 	require.False(t, b.HasRange(1023, 1025), "crossing into gap must not be reported as set")
 }
 
-// TestCardinalityInRange_LibraryBug documents an off-by-one in
-// roaring v2.16.0 runContainer16.getCardinalityInRange (line 2546):
-// "lastIdx < firstIdx-1" should be "lastIdx < firstIdx".
-// When the library fixes this, this test will fail and we can switch
-// HasRange from Rank() to CardinalityInRange().
-func TestCardinalityInRange_LibraryBug(t *testing.T) {
+// TestCardinalityInRange_GapFix verifies the fix for an off-by-one in
+// roaring v2.16.0 runContainer16.getCardinalityInRange (line 2546).
+// We use e2b-dev/roaring which includes the fix (upstream PR #521).
+// If this test breaks after switching back to upstream, the fix was
+// reverted or not yet merged.
+func TestCardinalityInRange_GapFix(t *testing.T) {
 	t.Parallel()
 	bm := roaring.New()
 	bm.AddRange(0, 1024)
 	bm.AddRange(2048, 3072)
 
-	card := bm.CardinalityInRange(1024, 2048)
-
-	// BUG: CardinalityInRange returns 1024 for a range with zero set bits.
-	// When this assertion fails, the library has been fixed and HasRange
-	// can be switched to use CardinalityInRange for O(k) instead of O(C).
-	require.Equal(t, uint64(1024), card,
-		"CardinalityInRange bug appears fixed — update HasRange to use it")
+	require.Equal(t, uint64(0), bm.CardinalityInRange(1024, 2048),
+		"gap between runs must have zero cardinality")
 }
 
 // --- Benchmarks ---