Skip to content

Commit 7a8a4b3

Browse files
committed
fix: address testifylint findings in reserved disk space test
Use assert.Positive and assert.Contains instead of assert.Greater and assert.True(strings.Contains(...)).
1 parent 3fd4020 commit 7a8a4b3

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

tests/integration/internal/tests/api/templates/reserved_disk_space_test.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import (
44
"context"
55
"regexp"
66
"strconv"
7-
"strings"
87
"testing"
98

109
"github.com/stretchr/testify/assert"
@@ -71,11 +70,11 @@ func TestTemplateBuildReservedDiskSpace(t *testing.T) {
7170
// Verify the reserved blocks are set (if the feature flag is enabled)
7271
// When BuildReservedDiskSpaceMB > 0, reserved blocks should be non-zero
7372
if reservedBlocks > 0 {
74-
assert.Greater(t, reservedSpaceMB, int64(0), "reserved space should be positive when reserved blocks are set")
73+
assert.Positive(t, reservedSpaceMB, "reserved space should be positive when reserved blocks are set")
7574
}
7675

7776
// Verify tune2fs output contains expected fields
78-
assert.True(t, strings.Contains(output, "Filesystem volume name:"), "tune2fs output should contain filesystem metadata")
77+
assert.Contains(t, output, "Filesystem volume name:", "tune2fs output should contain filesystem metadata")
7978

8079
t.Logf("tune2fs verification passed: %d reserved blocks (%d MB reserved)", reservedBlocks, reservedSpaceMB)
8180
}

0 commit comments

Comments
 (0)