Skip to content

Commit 9f4ed66

Browse files
authored
fix: remove ^orphan_file ext4 flag unsupported by older e2fsprogs (#2192)
Production orchestrators run e2fsprogs < 1.47.0 which does not recognize the orphan_file feature. Passing ^orphan_file to mkfs.ext4 on these older versions causes an "Invalid filesystem option set" error because the feature is entirely unknown, not just unsupported. Since orphan_file is only a default in e2fsprogs >= 1.47.0. Fixes: 5adcb7a ("feat: reserve disk space for guest OS during template build (#2082)")
1 parent 13d221c commit 9f4ed66

1 file changed

Lines changed: 0 additions & 6 deletions

File tree

  • packages/orchestrator/pkg/template/build/core/filesystem

packages/orchestrator/pkg/template/build/core/filesystem/ext4.go

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -55,12 +55,6 @@ func Make(ctx context.Context, rootfsPath string, sizeMb int64, blockSize int64)
5555
"huge_file",
5656
"large_file",
5757
"sparse_super2",
58-
59-
// Disabled for compatibility with older guest e2fsprogs (Ubuntu 22.04, Debian 11).
60-
// orphan_file was added as default in e2fsprogs >= 1.47.0; without disabling it,
61-
// guest tools fail with "unsupported read-only feature(s)".
62-
// See https://e2fsprogs.sourceforge.net/e2fsprogs-release.html#1.47.0
63-
"^orphan_file",
6458
}, ","),
6559
"-b", strconv.FormatInt(blockSize, 10),
6660
"-m", strconv.FormatInt(reservedBlocksPercentage, 10),

0 commit comments

Comments
 (0)