Skip to content

Commit d264863

Browse files
committed
test(uffd): restore TestSerial{Missing,MissingWrite} and TestParallelMissingWriteWithPrefault loads to 1_000_000
Continues the regression sweep started in 4681ab2. The original PR #1415 (88c3960, Nov 3 2025) introduced these tests at 1_000_000 operations. PR #1450 (6ee2ebb, Nov 7 2025, "Modify UFFD tests to run serve loop in a separate process") cut them all to 10_000 in the same commit that switched from in-process to cross-process tests, with no commit message justification. The cross-process refactor itself does not require lower iteration counts: the per-iteration work is still in-process memory access; only the page-state snapshot RPC is cross-process and is called once per test. Reverts: - TestSerialMissing: 10_000 -> 1_000_000 - TestSerialMissingWrite: 10_000 -> 1_000_000 - TestParallelMissingWriteWithPrefault: 10_000 -> 1_000_000 Per-test wall time on this branch (sudo go test, no -race): - TestSerialMissing ~3s - TestSerialMissingWrite ~3s - TestParallelMissingWriteWithPrefault ~2s TestParallelMissingWithPrefault stays at 10_000: it was only ever parallelOperations := 10 in #1415, then bumped to 10_000 in #1450, so 10_000 is already above its historical baseline.
1 parent 4681ab2 commit d264863

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

packages/orchestrator/pkg/sandbox/uffd/userfaultfd/missing_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@ func TestParallelMissingWithPrefault(t *testing.T) {
218218
func TestSerialMissing(t *testing.T) {
219219
t.Parallel()
220220

221-
serialOperations := 10_000
221+
serialOperations := 1_000_000
222222

223223
tt := testConfig{
224224
pagesize: header.PageSize,

packages/orchestrator/pkg/sandbox/uffd/userfaultfd/missing_write_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ func TestParallelMissingWrite(t *testing.T) {
173173
func TestParallelMissingWriteWithPrefault(t *testing.T) {
174174
t.Parallel()
175175

176-
parallelOperations := 10_000
176+
parallelOperations := 1_000_000
177177

178178
tt := testConfig{
179179
pagesize: header.PageSize,
@@ -213,7 +213,7 @@ func TestParallelMissingWriteWithPrefault(t *testing.T) {
213213
func TestSerialMissingWrite(t *testing.T) {
214214
t.Parallel()
215215

216-
serialOperations := 10_000
216+
serialOperations := 1_000_000
217217

218218
tt := testConfig{
219219
pagesize: header.PageSize,

0 commit comments

Comments
 (0)