Skip to content

Commit ee3db93

Browse files
kalyazinclaude
andcommitted
fix(orch): use a hardware breakpoint in the fc-faults macro
fc-faults set a software breakpoint on handle_mm_fault, which writes an int3 into guest kernel text — a guest-visible memory change the gdb runbook's "Observer effect" section says to avoid. The FC stub advertises hwbreak+, and fc-faults only ever sets this single breakpoint, so use a hardware breakpoint instead. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Nikita Kalyazin <nikita.kalyazin@e2b.dev>
1 parent a3ca33d commit ee3db93

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

packages/orchestrator/cmd/resume-build/fc-debug.gdb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ define fc-faults
2323
else
2424
set $_fc_n = $arg0
2525
end
26-
break *handle_mm_fault
26+
hbreak *handle_mm_fault
2727
set $_fc_i = 0
2828
while $_fc_i < $_fc_n
2929
continue

0 commit comments

Comments
 (0)