Filestore cache cleaner performance tweaks#1282
Merged
Merged
Conversation
- delete 900 files per loop (up from 100) - only remove a single file entry from cache, not the whole listing
ValentaTomas
approved these changes
Oct 1, 2025
ValentaTomas
pushed a commit
that referenced
this pull request
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Adds configurable filestore cleanup (disk target, dry-run, files/deletions per loop) and updates cleaner to remove single cache entries; aligns Nomad job/CLI flags.
filestore_max_disk_usage_targetwithfilestore_cache_cleanup_disk_usage_targetand addfilestore_cache_cleanup_dry_run,filestore_cache_cleanup_files_per_loop,filestore_cache_cleanup_deletions_per_loopiniac/provider-gcp/*with validations/defaults.jobs/clean-nfs-cache.hclto parameterize--dry-run, add--files-per-iterationand--deletions-per-iteration, and pass new vars innomad/clean-nfs-cache.tf.--max-files-per-iterationto--deletions-per-iteration.ListingCache.Decachenow removes only the specific file from the cached directory listing; addremoveByIndexhelper.DecacheandremoveByIndex.Written by Cursor Bugbot for commit ce362f5. This will update automatically on new commits. Configure here.