Skip to content

fix: template build panic handling#1289

Merged
dobrac merged 1 commit into
mainfrom
improve-template-build-panic-handling
Oct 2, 2025
Merged

fix: template build panic handling#1289
dobrac merged 1 commit into
mainfrom
improve-template-build-panic-handling

Conversation

@dobrac
Copy link
Copy Markdown
Contributor

@dobrac dobrac commented Oct 2, 2025

Fix template build panic handling to properly fail the build and report the error.


Note

Recover from panics during template builds, report them via telemetry with context, and mark the build as failed with a user-facing error.

  • Template Build (orchestrator):
    • Builder (internal/template/build/builder.go): Add panic recovery that reports a critical error via telemetry (with panic attribute, templateID, buildID) and returns a generic build error.
    • Server (internal/template/server/create_template.go): Replace panic log in background build with telemetry reporting and explicitly fail the build with a user-facing error.
  • Telemetry:
    • Import and use otel/attribute and shared telemetry package for structured error reporting.

Written by Cursor Bugbot for commit 97b59f0. This will update automatically on new commits. Configure here.

@dobrac dobrac added the bug Something isn't working label Oct 2, 2025
@e2b-request-same-site-reviewers e2b-request-same-site-reviewers Bot requested review from sitole and removed request for ValentaTomas and jakubno October 2, 2025 11:21
@dobrac dobrac changed the title Improve template build panic handling fix: template build panic handling Oct 2, 2025
@dobrac dobrac merged commit f98bba1 into main Oct 2, 2025
27 checks passed
@dobrac dobrac deleted the improve-template-build-panic-handling branch October 2, 2025 13:43
ValentaTomas pushed a commit that referenced this pull request May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants