Skip to content

Decrease the test reruns to 1 #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakubno merged 3 commits into from
Oct 2, 2025
Merged

Decrease the test reruns to 1 #1290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aa2c9ed
Decrease the rerun to 1
jakubno Oct 2, 2025
8e7d93c
Use gstatic for internet access test
jakubno Oct 2, 2025
881d013
Use gstatic for internet access test
jakubno Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/integration/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@ test/%:
*.go:*) \
BASE=$${TEST_PATH%%:*}; \
TEST_FN=$${TEST_PATH#*:}; \
go tool gotestsum --rerun-fails=2 --packages="$$BASE" --format standard-verbose --junitfile=test-results.xml -- -count=1 -parallel=4 -run "$${TEST_FN}" ;; \
*.go) go tool gotestsum --rerun-fails=2 --packages="$$TEST_PATH" --format standard-verbose --junitfile=test-results.xml -- -count=1 -parallel=4 ;; \
*) go tool gotestsum --rerun-fails=2 --packages="$$TEST_PATH/..." --format standard-verbose --junitfile=test-results.xml -- -count=1 -parallel=4 ;; \
go tool gotestsum --rerun-fails=1 --packages="$$BASE" --format standard-verbose --junitfile=test-results.xml -- -count=1 -parallel=4 -run "$${TEST_FN}" ;; \
*.go) go tool gotestsum --rerun-fails=1 --packages="$$TEST_PATH" --format standard-verbose --junitfile=test-results.xml -- -count=1 -parallel=4 ;; \
*) go tool gotestsum --rerun-fails=1 --packages="$$TEST_PATH/..." --format standard-verbose --junitfile=test-results.xml -- -count=1 -parallel=4 ;; \
esac

.PHONY: connect-orchestrator
Expand Down
4 changes: 2 additions & 2 deletions tests/integration/internal/tests/api/sandboxes/sandbox_internet_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ func TestInternetAccess(t *testing.T) {

envdClient := setup.GetEnvdClient(t, ctx)

err = utils.ExecCommand(t, ctx, resp.JSON201, envdClient, "curl", "--connect-timeout", "3", "--max-time", "5", "-Is", "https://www.google.com")
err = utils.ExecCommand(t, ctx, resp.JSON201, envdClient, "curl", "--connect-timeout", "3", "--max-time", "5", "-Is", "https://www.gstatic.com/generate_204")
if tc.internetAccess {
require.NoError(t, err, "Expected curl command to succeed when internet access is allowed")
} else {
Expand Down Expand Up @@ -98,7 +98,7 @@ func TestInternetAccessResumedSbx(t *testing.T) {
require.Equal(t, http.StatusCreated, respResume.StatusCode(), "Expected status code 200 OK, got %d", respResume.StatusCode())

envdClient := setup.GetEnvdClient(t, ctx)
err = utils.ExecCommand(t, ctx, resp.JSON201, envdClient, "curl", "--connect-timeout", "3", "--max-time", "5", "-Is", "https://www.google.com")
err = utils.ExecCommand(t, ctx, resp.JSON201, envdClient, "curl", "--connect-timeout", "3", "--max-time", "5", "-Is", "https://www.gstatic.com/generate_204")
Comment thread
cursor[bot] marked this conversation as resolved.
if tc.internetAccess {
require.NoError(t, err, "Expected curl command to succeed when internet access is allowed")
} else {
Expand Down
Loading