Skip to content

Add more events for uffd and nbd init #1398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ValentaTomas merged 3 commits into from
Oct 23, 2025
Merged

Add more events for uffd and nbd init #1398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b90eb57
Add event
ValentaTomas Oct 22, 2025
6131a36
Add nbd and uffd tracing events
ValentaTomas Oct 22, 2025
3a1e562
Merge branch 'main' into add-more-event
ValentaTomas Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/orchestrator/internal/sandbox/nbd/path_direct.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,11 +66,15 @@ func (d *DirectPathMount) Open(ctx context.Context) (retDeviceIndex uint32, err
zap.L().Debug("opening direct path mount", zap.Uint32("device_index", d.deviceIndex), zap.Error(err))
}()

telemetry.ReportEvent(ctx, "opening direct path mount")

size, err := d.Backend.Size()
if err != nil {
return math.MaxUint32, err
}

telemetry.ReportEvent(ctx, "got backend size")

deviceIndex := uint32(math.MaxUint32)

for {
Expand All @@ -79,6 +83,8 @@ func (d *DirectPathMount) Open(ctx context.Context) (retDeviceIndex uint32, err
return math.MaxUint32, err
}

telemetry.ReportEvent(ctx, "got device index")

d.socksClient = make([]*os.File, 0)
d.socksServer = make([]io.Closer, 0)
d.dispatchers = make([]*Dispatch, 0)
Expand Down Expand Up @@ -169,6 +175,8 @@ func (d *DirectPathMount) Open(ctx context.Context) (retDeviceIndex uint32, err
default:
}

telemetry.ReportEvent(ctx, "waiting for NBD connection")

s, err := nbdnl.Status(deviceIndex)
if err == nil && s.Connected {
break
Expand All @@ -177,6 +185,8 @@ func (d *DirectPathMount) Open(ctx context.Context) (retDeviceIndex uint32, err
time.Sleep(100 * time.Nanosecond)
}

telemetry.ReportEvent(ctx, "connected to NBD")

return deviceIndex, nil
}

Expand Down
4 changes: 4 additions & 0 deletions packages/orchestrator/internal/sandbox/sandbox.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -940,10 +940,14 @@ func serveMemory(
return nil, fmt.Errorf("failed to create uffd: %w", err)
}

telemetry.ReportEvent(ctx, "created uffd")

if err = fcUffd.Start(ctx, sandboxID); err != nil {
return nil, fmt.Errorf("failed to start uffd: %w", err)
}

telemetry.ReportEvent(ctx, "started uffd")

cleanup.Add(func(ctx context.Context) error {
_, span := tracer.Start(ctx, "uffd-stop")
defer span.End()
Expand Down