Skip to content

feat: feature flag guard provision version to allow rolling update#1399

Merged
dobrac merged 4 commits into
mainfrom
feature-guard-provision-version
Oct 27, 2025
Merged

feat: feature flag guard provision version to allow rolling update#1399
dobrac merged 4 commits into
mainfrom
feature-guard-provision-version

Conversation

@dobrac
Copy link
Copy Markdown
Contributor

@dobrac dobrac commented Oct 22, 2025

This should allow to gradually roll provision script update without invalidating all templates at the same time.


Note

Use a build-provision-version feature flag in base layer hashing to enable gradual provision script rollouts, wiring feature flags and contexts through the build pipeline.

  • Build Pipeline / Orchestrator:
    • Pass featureFlags into build.NewBuilder and base.New(...); store on Builder/BaseBuilder.
    • Use int flag BuildProvisionVersion in base.Hash(ctx, ...) to select provision version for cache keys; include TemplateContext and TeamContext.
    • Update BuilderPhase.Hash signature to Hash(ctx, ...) and adjust implementations in base, finalize, steps, and user.
  • Feature Flags:
    • Add TemplateKind and TemplateContext; add BuildProvisionVersion int flag.
    • Split team contexts: new TeamContextWithName(teamID, teamName) and TeamContext(teamID); API middleware now uses TeamContextWithName.
  • Wiring/Infra:
    • Propagate featureFlags client through template server, CLI build tool, benchmarks, and orchestrator startup.

Written by Cursor Bugbot for commit 0b49d47. This will update automatically on new commits. Configure here.

@dobrac dobrac added the improvement Improvement for current functionality label Oct 22, 2025
@dobrac dobrac marked this pull request as ready for review October 22, 2025 23:58
cursor[bot]

This comment was marked as outdated.

@dobrac dobrac force-pushed the feature-guard-provision-version branch from c2a2c1e to 21b5913 Compare October 23, 2025 00:01
Comment thread packages/orchestrator/internal/template/build/phases/base/hash.go Outdated
@dobrac dobrac requested a review from djeebus October 23, 2025 00:05
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@dobrac dobrac enabled auto-merge (squash) October 27, 2025 10:25
@dobrac dobrac merged commit fd02c95 into main Oct 27, 2025
26 checks passed
@dobrac dobrac deleted the feature-guard-provision-version branch October 27, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement for current functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants