fix: list dir with depth > 3#1402
Merged
Merged
Conversation
Bug: WalkDir Silently Ignores Critical ErrorsThe |
Bug:
|
sitole
approved these changes
Oct 23, 2025
ValentaTomas
pushed a commit
that referenced
this pull request
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix panic in envd causing list directory with depth > 3 to fail.
The error after fixing the panic was the following. The file didn't exist between the walkdir calls. I think it's safe to ignore these when walking a directory.
Note
Skips entries that disappear during directory traversal and updates envd version to 0.4.2.
packages/envd/internal/services/filesystem/dir.go):walkDir: ignorenot_founderrors by skipping entries that no longer exist during traversal; replace unusedentryparam with_.errorsimport and use error unwrapping to detectconnect.CodeNotFound.packages/envd/main.go):Versionfrom0.4.1to0.4.2.Written by Cursor Bugbot for commit 2669741. This will update automatically on new commits. Configure here.