Skip to content

Return correct status code for non existing sandbox in orchestrator in keep alive#1405

Merged
jakubno merged 3 commits into
mainfrom
return-correct-status-code-for-non-existing-sandbox-in-keep-alive
Oct 27, 2025
Merged

Return correct status code for non existing sandbox in orchestrator in keep alive#1405
jakubno merged 3 commits into
mainfrom
return-correct-status-code-for-non-existing-sandbox-in-keep-alive

Conversation

@jakubno
Copy link
Copy Markdown
Member

@jakubno jakubno commented Oct 27, 2025

Note

Propagates gRPC NotFound to return API 404 when keeping a sandbox alive that no longer exists.

  • Backend / Orchestrator:
    • keep_alive.go:
      • Map ErrSandboxNotFound from UpdateSandbox to API 404 Not Found during KeepAliveFor.
    • update_instance.go:
      • Inspect gRPC status; if codes.NotFound, return ErrSandboxNotFound.
      • Continue unwrapping and wrapping other errors as before.

Written by Cursor Bugbot for commit 0ebeba8. This will update automatically on new commits. Configure here.

@jakubno jakubno added the bug Something isn't working label Oct 27, 2025
@jakubno jakubno force-pushed the return-correct-status-code-for-non-existing-sandbox-in-keep-alive branch from ecf19e8 to 66fa7da Compare October 27, 2025 18:39
@jakubno jakubno marked this pull request as ready for review October 27, 2025 18:39
@jakubno jakubno force-pushed the return-correct-status-code-for-non-existing-sandbox-in-keep-alive branch from 1e8d07a to 0ebeba8 Compare October 27, 2025 18:59
@jakubno jakubno enabled auto-merge (squash) October 27, 2025 19:00
@jakubno jakubno merged commit 04ba19b into main Oct 27, 2025
26 checks passed
@jakubno jakubno deleted the return-correct-status-code-for-non-existing-sandbox-in-keep-alive branch October 27, 2025 19:11
ValentaTomas pushed a commit that referenced this pull request May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants