feat: return templates that are building for the first time#1406
Merged
dobrac merged 1 commit intoOct 27, 2025
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
dobrac
force-pushed
the
return-also-templates-that-are-building-for-the-first-time-eng-3222
branch
from
45534fd to
f359e53
Compare
| LastSpawnedAt: item.Env.LastSpawnedAt, | ||
| SpawnCount: item.Env.SpawnCount, | ||
| BuildCount: item.Env.BuildCount, | ||
| BuildStatus: api.TemplateBuildStatus(item.BuildStatus), |
There was a problem hiding this comment.
Bug: Status Mapping Error in API Response
Direct casting of database status to API status without proper mapping. The database uses status values like 'uploaded', 'failed', 'success', 'snapshotting' which don't match the API enum values ('ready', 'error', 'building', 'waiting'). This will cause invalid enum values to be returned in the API response. The code should use the existing getCorrespondingTemplateBuildStatus function from template_build_status.go to properly map database status values to API status values.
jakubno
requested changes
Oct 27, 2025
jakubno
approved these changes
Oct 27, 2025
dobrac
deleted the
return-also-templates-that-are-building-for-the-first-time-eng-3222
branch
ValentaTomas
pushed a commit
that referenced
this pull request
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Adds buildStatus to Template API and updates listing to include templates with the latest build (including in-progress).
buildStatustoTemplateand define reusableTemplateBuildStatusenum; reference it inTemplateBuild.status.spec.gen.go,types.gen.go, test models).get_team_templatesto returneb.status AS build_statusand removestatus = 'uploaded'filter to select the latest build.Template.buildStatusinGetTemplatesfrom query result.Written by Cursor Bugbot for commit f359e53. This will update automatically on new commits. Configure here.