Fix bug when connecting to a sandbox with a longer timeout#1412
Closed
jakubno wants to merge 4 commits into
Closed
Fix bug when connecting to a sandbox with a longer timeout#1412jakubno wants to merge 4 commits into
jakubno wants to merge 4 commits into
Conversation
jakubno
commented
Oct 28, 2025
| ) | ||
|
|
||
| func (o *Orchestrator) KeepAliveFor(ctx context.Context, sandboxID string, duration time.Duration, allowShorter bool) *api.APIError { | ||
| func (o *Orchestrator) KeepAliveFor(ctx context.Context, sandboxID string, duration time.Duration, extendOnly bool) *api.APIError { |
Member
Author
There was a problem hiding this comment.
renamed it here to keep it consistent with API. I wanted to add a parameter which is description + default false
Contributor
|
whats the difference between set timeout extend_only=True and refresh? |
5cf1945 to
0106d1c
Compare
Member
Author
none, but Also in SDK you probably don't want to do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Adds
extend_onlyto sandbox timeout to control TTL extension vs reset, updates orchestrator/handlers accordingly, deprecates refresh endpoint, and adds integration tests.POST /sandboxes/{sandboxID}/timeout: addextend_only(defaultfalse) to control extending vs setting a new TTL.POST /sandboxes/{sandboxID}/refreshes: marked as deprecated.spec.gen.go,types.gen.go, test models) updated.KeepAliveForparam toextendOnlyand enforce non-shortening when true.KeepAliveFor(..., extendOnly=true).extend_onlyand passes through.extend_only=true, shortening when false/omitted, and not-found case.Written by Cursor Bugbot for commit 9224e82. This will update automatically on new commits. Configure here.