feat(orch): add ScallignDown status#2146
Merged
Merged
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
jakubno
force-pushed
the
feat/add-ineligible-state-for-orchestrator
branch
from
df5b598 to
47e6213
Compare
dobrac
reviewed
Mar 19, 2026
dobrac
left a comment
dobrac
left a comment
Contributor
There was a problem hiding this comment.
could we name it differently? To me it seems more like draining and scaling down should be switched in its meaning -> rename the new state.
dobrac
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Introduces a new node/orchestrator status across API, gRPC, and health reporting, which can affect routing and automation that keys off status/health values. Main risk is backward-compatibility and unexpected behavior if consumers don’t recognize
standbyor rely ondrainingsemantics.Overview
Adds a new
standbynode/orchestrator state end-to-end (OpenAPI + generated clients, gRPCServiceInfoStatus, and API↔orchestrator mappers) with clarified status semantics. Updates orchestrator health reporting to treatstandbyasdraining, and adjusts shutdown draining logic to transition from eitherhealthyorstandbyintodrainingwithout overriding externally-set states.Written by Cursor Bugbot for commit 334d097. This will update automatically on new commits. Configure here.