fix(api): downgrade client cancellation from error to warning#2158
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
80d28a9 to
c972f24
Compare
When a client disconnects (user cancel or LB timeout), the request context is canceled. Previously this was logged at Error level and marked as an error span in OTEL traces, creating noise alongside real server errors. Now context.Canceled is detected in both the logging middleware and the OTEL tracing middleware: log level is downgraded to Warn and the span gets a client.canceled attribute instead of an error status.
c972f24 to
8a016ee
Compare
jakubno
approved these changes
Mar 18, 2026
ValentaTomas
pushed a commit
that referenced
this pull request
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
context.Canceledin the logging middleware and OTEL tracing middleware to distinguish client disconnects from real server errorsclient.canceled=truespan attribute instead of marking the span as an error statusNote
Medium Risk
Small change but it alters how 5xx requests are classified in logs and OpenTelemetry spans, which can impact alerting and error-rate dashboards if cancellation detection is wrong.
Overview
Adjusts request observability to distinguish client disconnects from server failures: the logging middleware no longer emits 5xx responses as
Errorwhen the request context iscontext.Canceled, and the OTEL tracing middleware avoids setting an error span status for canceled requests, instead tagging spans withclient.canceled=true.Written by Cursor Bugbot for commit 3da0327. This will update automatically on new commits. Configure here.