chore(api): RequestTimeout + distinguish between client cancel and request timeout in telemetry#2165
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
jakubno
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fdcc1d59ef
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
jakubno
changed the title
dobrac
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables RequestTimeout with 70s deadline
Note
Medium Risk
Introduces a new per-request context deadline and changes how cancellations are classified in logs/traces/metrics, which can affect long-running endpoints and observability signals if misclassified.
Overview
Enables a 70s per-request
RequestTimeoutacross the API and centralizes the middleware inshared/pkg/middlewareusingcontext.WithTimeoutCauseso callers can distinguish server-side timeouts from client disconnects. Updates logging, tracing, and metrics to recordErrRequestTimeoutvscontext.Canceled(including emitting 499 viaStatusClientClosedRequestand settingrequest.timeout/client.canceledattributes) based on the captured cancel cause, and adjusts timeout tests to validate the new cancel-cause behavior.Written by Cursor Bugbot for commit 44afa40. This will update automatically on new commits. Configure here.