fix: remove GCP-specific arg from AWS orchestrator module#2177
Merged
Conversation
…strator module The orchestrator module accepts gcs_grpc_connection_pool_size inside provider_gcp_config, not as a top-level argument. This causes terraform plan to fail on the AWS provider. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ya-luotao
requested review from
ValentaTomas,
dobrac and
jakubno
as code owners
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
jakubno
approved these changes
Mar 19, 2026
Member
|
Thanks @ya-luotao! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gcs_grpc_connection_pool_sizefrom the AWS provider's orchestrator module call iniac/provider-aws/nomad/main.tfprovider_gcp_config, not as a top-level variableterraform planto fail on the AWS provider with:An argument named "gcs_grpc_connection_pool_size" is not expected hereTest plan
terraform planfails on AWS provider without this fixterraform planon AWS provider after this fix🤖 Generated with Claude Code