chore(orch): split mkfs.ext4 feature flags into individually commentable slice#2183
Merged
Conversation
…ble slice Replace the single comma-separated string literal for mkfs.ext4 -O with strings.Join over a slice, so each ext4 feature flag can be commented individually. Flags are sorted alphabetically within the main group, with ^orphan_file separated at the end as a guest-compatibility workaround. Original comments describing the feature set rationale (tar2ext4 matching, kept defaults, orphan_file compat) are preserved in place. No functional change - produces the identical argument string at runtime. Addresses review feedback from #2082. Link: #2082 (comment)
sitole
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the single comma-separated string literal for
mkfs.ext4 -Owithstrings.Joinover a slice, so each ext4 feature flag can be commented individually. Flags are sorted alphabetically within the main group, with^orphan_fileseparated at the end as a guest-compatibility workaround.Original comments describing the feature set rationale (
tar2ext4matching, kept defaults,orphan_filecompat) are preserved in place.No functional change - produces the identical argument string at runtime.
Addresses review feedback from #2082.
Note
Low Risk
Low risk refactor of a command argument construction; main risk is accidentally changing flag ordering/content, but the intended runtime string is unchanged.
Overview
Updates
Makeinext4.goto build themkfs.ext4 -Ofeature list viastrings.Joinover an individually commented slice (with^orphan_filekept as a dedicated compatibility workaround), rather than a single hard-coded comma-separated string, with no intended behavioral change.Written by Cursor Bugbot for commit dd9341d. This will update automatically on new commits. Configure here.