Skip to content

Only wait up to 5 seconds to mount nfs#2317

Merged
djeebus merged 9 commits intomainfrom
small-fixes
Apr 8, 2026
Merged

Only wait up to 5 seconds to mount nfs#2317
djeebus merged 9 commits intomainfrom
small-fixes

Conversation

@djeebus
Copy link
Copy Markdown
Contributor

@djeebus djeebus commented Apr 7, 2026

Failures to mount are currently causing envd to block and api requests to timeout. No reason for that.


Open with Devin

@cursor
Copy link
Copy Markdown

cursor bot commented Apr 7, 2026

PR Summary

Medium Risk
Changes init-time volume mounting behavior by adding a 5s timeout and skipping/deduping mounts, which could leave volumes unmounted in slow or transient NFS scenarios but avoids request hangs.

Overview
This PR makes /init NFS volume mounting non-blocking for overall system responsiveness by adding a 5-second mount timeout, preventing concurrent re-mount attempts, and tracking already-mounted paths so repeated init calls don’t re-run mounts; it also bumps the envd version to 0.5.11.

Reviewed by Cursor Bugbot for commit 78d5310. Bugbot is set up for automated code reviews on this repo. Configure here.

chatgpt-codex-connector[bot]

This comment was marked as resolved.

@@ -1,10 +1,5 @@
variable "cluster_size" {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the cluster_size >= 1 validation is a regression. Without it, cluster_size = 0 is silently accepted at plan time, which would result in a zero-node worker cluster. If autoscaling can manage the count to zero that is fine, but then the validation should be >= 0 rather than removed entirely.

cursor[bot]

This comment was marked as resolved.

claude[bot]

This comment was marked as resolved.

@djeebus djeebus changed the title Only wait up to 5 seconds to mount nfs Only wait up to 5 seconds to mount nfs, support cluster scale-to-zero Apr 7, 2026
@djeebus djeebus marked this pull request as draft April 7, 2026 20:02
cursor[bot]

This comment was marked as resolved.

cursor[bot]

This comment was marked as resolved.

@djeebus djeebus marked this pull request as ready for review April 8, 2026 20:55
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.

Once credits are available, reopen this pull request to trigger a review.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 93b888ae4e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@djeebus djeebus changed the title Only wait up to 5 seconds to mount nfs, support cluster scale-to-zero Only wait up to 5 seconds to mount nfs Apr 8, 2026
@dobrac dobrac assigned dobrac and unassigned matthewlouisbrockman Apr 8, 2026
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional findings.

Open in Devin Review

@djeebus djeebus merged commit b781ad4 into main Apr 8, 2026
44 checks passed
@djeebus djeebus deleted the small-fixes branch April 8, 2026 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants