Skip to content

Fix bun template install#2460

Merged
djeebus merged 4 commits intomainfrom
fix-bun-for-reals
Apr 20, 2026
Merged

Fix bun template install#2460
djeebus merged 4 commits intomainfrom
fix-bun-for-reals

Conversation

@djeebus
Copy link
Copy Markdown
Contributor

@djeebus djeebus commented Apr 20, 2026

turns out bun auto reads .env.local, which we don't want

https://bun.com/docs/runtime/environment-variables

turns out bun auto reads .env.local, which we don't want
@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 20, 2026

PR Summary

Low Risk
Low risk CI-only change, but the added rm .env.local can fail the workflow if the file doesn’t exist or the working directory changes unexpectedly.

Overview
Updates the base-template GitHub Actions workflow to explicitly remove .env.local before running bun install/build so Bun doesn’t auto-load local env vars, and tweaks the manual dispatch environment choices; consider using rm -f to avoid failing builds when .env.local is absent.

Reviewed by Cursor Bugbot for commit 4acf535. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 4acf535. Configure here.

Comment thread .github/workflows/deploy-base-template.yml
Comment thread .github/workflows/deploy-base-template.yml
@djeebus djeebus enabled auto-merge (squash) April 20, 2026 21:18
@djeebus djeebus merged commit ff162ad into main Apr 20, 2026
45 checks passed
@djeebus djeebus deleted the fix-bun-for-reals branch April 20, 2026 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants