Skip to content

Change README title to 'E2B Infrastructure test'#2574

Closed
dobrac wants to merge 1 commit into
mainfrom
dobrac-patch-1
Closed

Change README title to 'E2B Infrastructure test'#2574
dobrac wants to merge 1 commit into
mainfrom
dobrac-patch-1

Conversation

@dobrac
Copy link
Copy Markdown
Contributor

@dobrac dobrac commented May 5, 2026

Updated the title of the README to include 'test'.

Updated the title of the README to include 'test'.
@cla-bot cla-bot Bot added the cla-signed label May 5, 2026
@cursor
Copy link
Copy Markdown

cursor Bot commented May 5, 2026

PR Summary

Low Risk
Low risk documentation-only change; main concern is that adding "test" to the README title may be accidental and confusing for users.

Overview
The README heading is changed from E2B Infrastructure to E2B Infrastructure test, which may be unintended and could make the project appear non-production or in-progress.

Reviewed by Cursor Bugbot for commit 970123e. Bugbot is set up for automated code reviews on this repo. Configure here.

@qodo-code-review
Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Qodo Logo

@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
2499 2 2497 7
View the full list of 3 ❄️ flaky test(s)
github.com/e2b-dev/infra/tests/integration/internal/tests/api/metrics::TestTeamMetrics

Flake rate in main: 50.00% (Passed 9 times, Failed 9 times)

Stack Traces | 2.58s run time
=== RUN   TestTeamMetrics
=== PAUSE TestTeamMetrics
=== CONT  TestTeamMetrics
    team_metrics_test.go:61: 
        	Error Trace:	.../api/metrics/team_metrics_test.go:61
        	Error:      	Should be true
        	Test:       	TestTeamMetrics
        	Messages:   	MaxConcurrentSandboxes should be >= 0
--- FAIL: TestTeamMetrics (2.58s)
github.com/e2b-dev/infra/tests/integration/internal/tests/api/sandboxes::TestUpdateNetworkConfig

Flake rate in main: 56.00% (Passed 11 times, Failed 14 times)

Stack Traces | 88.8s run time
=== RUN   TestUpdateNetworkConfig
=== PAUSE TestUpdateNetworkConfig
=== CONT  TestUpdateNetworkConfig
Executing command ssh in sandbox in7tb4fzcx4h32o232qa2
--- FAIL: TestUpdateNetworkConfig (88.82s)
github.com/e2b-dev/infra/tests/integration/internal/tests/api/sandboxes::TestUpdateNetworkConfig/pause_resume_preserves_allow_internet_access_false

Flake rate in main: 50.00% (Passed 11 times, Failed 11 times)

Stack Traces | 0.8s run time
=== RUN   TestUpdateNetworkConfig/pause_resume_preserves_allow_internet_access_false
Executing command curl in sandbox ilfktcyzrznn6phwnykwg
    sandbox_network_update_test.go:372: Command [curl] output: event:{start:{pid:1364}}
    sandbox_network_update_test.go:372: Command [curl] output: event:{end:{exit_code:35 exited:true status:"exit status 35" error:"exit status 35"}}
Executing command curl in sandbox ilfktcyzrznn6phwnykwg
    sandbox_network_update_test.go:372: Command [curl] output: event:{start:{pid:1365}}
    sandbox_network_update_test.go:372: Command [curl] output: event:{end:{exit_code:35 exited:true status:"exit status 35" error:"exit status 35"}}
    sandbox_network_update_test.go:391: Command [curl] output: event:{start:{pid:1366}}
    sandbox_network_update_test.go:391: Command [curl] output: event:{data:{stdout:"HTTP/2 302 \r\nx-content-type-options: nosniff\r\nlocation: https://dns.google/\r\ndate: Tue, 05 May 2026 20:15:35 GMT\r\ncontent-type: text/html; charset=UTF-8\r\nserver: HTTP server (unknown)\r\ncontent-length: 216\r\nx-xss-protection: 0\r\nx-frame-options: SAMEORIGIN\r\nalt-svc: h3=\":443\"; ma=2592000,h3-29=\":443\"; ma=2592000\r\n\r\n"}}
    sandbox_network_update_test.go:391: Command [curl] output: event:{end:{exited:true status:"exit status 0"}}
    sandbox_network_update_test.go:391: Command [curl] completed successfully in sandbox ilfktcyzrznn6phwnykwg
    sandbox_network_update_test.go:391: 
        	Error Trace:	.../api/sandboxes/sandbox_network_out_test.go:74
        	            				.../api/sandboxes/sandbox_network_update_test.go:60
        	            				.../api/sandboxes/sandbox_network_update_test.go:391
        	Error:      	An error is expected but got nil.
        	Test:       	TestUpdateNetworkConfig/pause_resume_preserves_allow_internet_access_false
        	Messages:   	https://8.8.8.8 should be blocked
--- FAIL: TestUpdateNetworkConfig/pause_resume_preserves_allow_internet_access_false (0.80s)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 970123e. Configure here.

Comment thread README.md
![E2B Infra Preview Dark](/readme-assets/infra-dark.png#gh-dark-mode-only)

# E2B Infrastructure
# E2B Infrastructure test
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test artifact in README title

Low Severity

The README title includes "test", which appears to be temporary text. This creates an inconsistency with the project's canonical name used elsewhere in the repository and may degrade the professional appearance of the GitHub landing page.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 970123e. Configure here.

Comment thread README.md
![E2B Infra Preview Dark](/readme-assets/infra-dark.png#gh-dark-mode-only)

# E2B Infrastructure
# E2B Infrastructure test
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 The README H1 was changed from # E2B Infrastructure to # E2B Infrastructure test, which looks accidental — the rest of the README (e.g. line 12, "ways you can contribute to E2B Infrastructure") still uses the unsuffixed name, and the PR description doesn't give a reason for adding "test" to a public-facing project title. Since GitHub renders this H1 on the repo landing page, please confirm the intent before merging; if the rename is genuinely desired the other references should be updated for consistency, otherwise revert this line back to # E2B Infrastructure.

Extended reasoning...

What changed. The single-file diff updates the H1 of README.md from # E2B Infrastructure to # E2B Infrastructure test. This is the entire content of the PR.

Why this is worth flagging. The README's H1 is what GitHub renders at the top of the e2b-dev/infra repo landing page, so it functions as the public name of the project on the repo's front door. Appending the word "test" carries no product meaning, and the rest of the same README continues to refer to the project as "E2B Infrastructure" without the suffix — for example, the Contributing section still says "ways you can contribute to E2B Infrastructure". The result is an inconsistent, public-facing title that reads as if the project were a non-production or staging artifact.

Why the PR description doesn't resolve the concern. The description ("Updated the title of the README to include test.") restates the diff but offers no rationale — there's no linked issue, no rebrand context, and no indication that downstream references (CONTRIBUTING.md, self-host docs, marketing copy) are being updated to match. Cursor Bugbot independently flagged the same concern in the PR timeline as a low-risk advisory.

Addressing the refutation. One verifier argued this is purely an editorial decision matching the PR's stated intent and therefore not a "bug." That's a fair point about scope — there is no code, security, or runtime defect here, which is why this is filed as a nit rather than a blocker. However, public-facing branding regressions on a production open-source infra repo are still worth surfacing for human confirmation, especially when (a) the change is one line, (b) the word "test" strongly suggests an accidental commit, and (c) the rest of the file is internally inconsistent with the new title. Surfacing it as a review comment lets the maintainer affirm intent rather than silently land a likely-accidental rename.

Step-by-step proof of the inconsistency.

  1. Open README.md after this PR is applied.
  2. Line 4 reads: # E2B Infrastructure test.
  3. Line 12 reads: See [CONTRIBUTING.md](./CONTRIBUTING.md) for ways you can contribute to E2B Infrastructure. — note the project is referred to without "test".
  4. Render the file (or view the repo on GitHub): the page title is "E2B Infrastructure test" while the body text refers to "E2B Infrastructure". The two are visibly inconsistent within a single document.

How to fix. If the rename is unintended, revert line 4 back to # E2B Infrastructure. If the rename is intended for some reason, update the other in-file references (and any sibling docs such as CONTRIBUTING.md and self-host.md) so the project name is used consistently, and add a brief justification to the PR description.

🔬 also observed by cursor[bot]

@dobrac dobrac closed this May 5, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

I have no feedback to provide.

@ValentaTomas ValentaTomas deleted the dobrac-patch-1 branch May 11, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants