feat(api): emit firecracker_version + kernel_version on created_instance posthog event#2583
Merged
ValentaTomas merged 1 commit intomainfrom May 6, 2026
Merged
Conversation
PR SummaryLow Risk Overview Reviewed by Cursor Bugbot for commit 0c12ada. Bugbot is set up for automated code reviews on this repo. Configure here. |
❌ 12 Tests Failed:
View the full list of 15 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require review |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM, two-field analytics addition using already-populated sandbox struct fields.
Extended reasoning...
Overview
This PR adds two properties (firecracker_version and kernel_version) to the existing created_instance PostHog event in packages/api/internal/orchestrator/analytics.go. Both values come from fields already present on the sandbox.Sandbox struct, so there are no upstream changes needed.
Security risks
None. This is purely analytics emission of pre-existing internal version strings to PostHog. No new external input, no auth/permission changes, no data exfil concerns beyond what is already being emitted.
Level of scrutiny
Low. This is a 2-line additive change to a posthog properties builder, following the exact same .Set(key, sbx.Field) pattern as the surrounding lines. There are no logic branches, no error handling implications, and no behavior changes for existing consumers.
Other factors
The bug hunting system found no issues. Cursor Bugbot flagged only the theoretical risk that FirecrackerVersion/KernelVersion could be empty for some start paths, which would just produce blank PostHog properties rather than any functional bug. Codecov's failing tests are all known flaky integration tests with very high flake rates on main and are unrelated to this change.
dobrac
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two properties to the
created_instancePostHog event inpackages/api/internal/orchestrator/analytics.go:firecracker_version—sbx.FirecrackerVersionkernel_version—sbx.KernelVersionBoth fields already exist on
sandbox.Sandbox(set from the build at sandbox start), so no upstream changes needed.