Conversation
❌ 12 Tests Failed:
View the full list of 14 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f70a225f1e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
Truncating Kubernetes pod names to a fixed length will cause ID collisions because pod names in a controller share common prefixes, leading to incorrect routing or state corruption. Using string formatting to join IP addresses and ports fails for IPv6 hosts; net.JoinHostPort should be used to ensure correct formatting. The K8sNamespace configuration field lacks a default value or requirement check, which may cause the client to query all namespaces and fail due to RBAC restrictions.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8d7f7d6184
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
tvi
force-pushed
the
t/kk
branch
2 times, most recently
from
2cf4f2a to
3fcf006
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: edb90a4eb4
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…late-manager
Adds Kubernetes implementations of the Discovery interface (introduced
in the previous commit) and wires them in via a new config switch.
- cfg.ServiceDiscoveryProvider ('nomad' default, or 'kubernetes'),
plus K8sNamespace and label-selector env vars for the orchestrator
and template-manager pods
- new orchestrator/discovery.KubernetesDiscovery and
clusters/discovery.KubernetesServiceDiscovery; both list pods by
label selector in the api's namespace, filter to Running+Ready,
and use status.HostIP (orchestrator/template-manager pods run with
host_network=true) as the address. Discovered nodes are addressed
on consts.OrchestratorAPIPort.
- the K8s backend uses the full pod name as the discovery ShortID
rather than truncating to consts.NodeIDLength like the Nomad
backend does. Nomad node IDs are UUIDs whose first 8 hex chars are
effectively unique; pod names share a long DaemonSet/Deployment
prefix and would collide under that truncation, collapsing every
orchestrator pod into a single discovery key and silently dropping
all but one. The ShortID is opaque to downstream consumers
(string-compare key only), so relaxing the width invariant for
K8s only is safe. The tradeoff is documented inline.
- handlers/store.go selects the implementation at startup; when
PROVIDER=kubernetes both discoveries share an in-cluster K8s
client built from rest.InClusterConfig
Behavior preserved: with the default SERVICE_DISCOVERY_PROVIDER=nomad
the api still talks to the local Nomad agent exactly as before, so the
existing Nomad deploy is unaffected.
ValentaTomas
approved these changes
May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…late-manager
Adds Kubernetes implementations of the Discovery interface (introduced in the previous commit) and wires them in via a new config switch.
Behavior preserved: with the default SERVICE_DISCOVERY_PROVIDER=nomad the api still talks to the local Nomad agent exactly as before, so the existing Nomad deploy is unaffected.