test: replace context.Background() with t.Context()/b.Context() in tests#2613
Merged
Conversation
PR SummaryLow Risk Overview Reviewed by Cursor Bugbot for commit 633e474. Bugbot is set up for automated code reviews on this repo. Configure here. |
❌ 10 Tests Failed:
View the full list of 10 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
dobrac
approved these changes
May 10, 2026
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
Cleanup operations and finish callbacks in autoresume_test.go and state_change_test.go must use context.Background() instead of t.Context(). The test context is cancelled as soon as the test function returns, which will cause any subsequent context-aware I/O in these callbacks to fail, potentially leaving the system in an inconsistent state or causing flaky tests.
Tests now use the testing.T/B/F context binding introduced in Go 1.24
instead of context.Background(). The bound context is cancelled when the
test finishes, so any goroutines or in-flight operations spawned by a
test get stopped automatically when the test exits or times out — this
avoids goroutine leaks and surfaces lifetime bugs that context.Background()
silently masks.
Mechanical replacement across 31 test files:
- ctx := context.Background() -> ctx := t.Context()
- context.WithCancel(context.Background()) -> context.WithCancel(t.Context())
- context.WithTimeout(context.Background(), …) -> context.WithTimeout(t.Context(), …)
- Inside *testing.B benchmarks -> b.Context()
- Inside helpers taking testing.TB -> tb.Context()
- ratelimit doRequest helper now takes *testing.T so it can use t.Context()
- Removed now-unused "context" imports where no other context.* usage remained
Intentionally left as context.Background():
- t.Cleanup(...) callbacks: t.Context() is cancelled BEFORE cleanups run,
so passing it to Close()/Terminate() would abort the cleanup operation.
- Helpers without a *testing.T/B in scope (e.g. proxy_test.go newTestBackend,
uffd/userfaultfd/rpc_services_test.go subprocess harness).
- Unreachable defensive fallbacks of the form
`if parentCtx == nil { parentCtx = context.Background() }`
in placement_benchmark_test.go after b.Context() (which never returns nil).
Verified with `go vet` and `go test -run=NONE` (compile-only) across all
affected packages, including GOOS=linux for build-tagged orchestrator tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests now use the testing.T/B/F context binding introduced in Go 1.24 instead of context.Background(). The bound context is cancelled when the test finishes, so any goroutines or in-flight operations spawned by a test get stopped automatically when the test exits or times out — this avoids goroutine leaks and surfaces lifetime bugs that context.Background() silently masks.
Mechanical replacement across 31 test files:
Intentionally left as context.Background():
if parentCtx == nil { parentCtx = context.Background() }in placement_benchmark_test.go after b.Context() (which never returns nil).Verified with
go vetandgo test -run=NONE(compile-only) across all affected packages, including GOOS=linux for build-tagged orchestrator tests.