feat(api): singleflight per sandbox, 256-concurrency cap, in-flight gauge#2625
Merged
Conversation
…flight gauge Dedupe overlapping eviction attempts for the same sandbox via singleflight, cap concurrent evictions at 256 using errgroup.TryGo so the ticker loop never blocks, and expose an observable gauge (api.evictor.evictions.running) for the in-flight count.
PR SummaryMedium Risk Overview Reviewed by Cursor Bugbot for commit f56fd8b. Bugbot is set up for automated code reviews on this repo. Configure here. |
❌ 6 Tests Failed:
View the full list of 9 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
The use of singleflight.Do inside the errgroup goroutine can lead to starvation because it blocks while waiting for the same sandbox ID, potentially filling all 256 slots with redundant goroutines and preventing the evictor from processing other sandboxes. Replacing singleflight with a sync.Map to track active sandbox IDs and skipping the TryGo call if an eviction is already in progress avoids this blocking and ensures slots remain available for other tasks.
…arvation singleflight.Do blocked inside the errgroup goroutine, so duplicate ticks for the same slow-evicting sandbox piled up as waiters and could exhaust the 256 concurrency cap. Switch to a sync.Map LoadOrStore check before TryGo so duplicates short-circuit without consuming a slot, and derive the in-flight gauge from the map directly.
jakubno
changed the title
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
An organization admin can view or raise the cap at claude.ai/admin-settings/claude-code. The cap resets at the start of the next billing period.
Once the cap resets or is raised, reopen this pull request to trigger a review.
arkamar
approved these changes
May 12, 2026
ValentaTomas
pushed a commit
that referenced
this pull request
May 13, 2026
…auge (#2625) Dedupe overlapping eviction attempts for the same sandbox via `singleflight`, cap concurrent evictions at **256** using `errgroup.TryGo` so the ticker loop never blocks, and expose an observable gauge (api.evictor.evictions.running) for the in-flight count.
AdaAibaby
pushed a commit
to AdaAibaby/infra
that referenced
this pull request
May 14, 2026
…auge (e2b-dev#2625) Dedupe overlapping eviction attempts for the same sandbox via `singleflight`, cap concurrent evictions at **256** using `errgroup.TryGo` so the ticker loop never blocks, and expose an observable gauge (api.evictor.evictions.running) for the in-flight count.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dedupe overlapping eviction attempts for the same sandbox via
singleflight, cap concurrent evictions at 256 usingerrgroup.TryGoso the ticker loop never blocks, and expose an observable gauge (api.evictor.evictions.running) for the in-flight count.