Skip to content

fix(auth): skip expected missing-header telemetry #2645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tvi wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −5
Draft

fix(auth): skip expected missing-header telemetry #2645

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions packages/auth/pkg/auth/middleware.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,13 @@ func (a *CommonAuthenticator[T]) GetHeaderKeysFromRequest(req *http.Request) (st
func (a *CommonAuthenticator[T]) Authenticate(ctx context.Context, ginCtx *gin.Context, input *openapi3filter.AuthenticationInput) error {
headerKey, err := a.GetHeaderKeysFromRequest(input.RequestValidationInput.Request)
if err != nil {
telemetry.ReportError(ctx,
"authorization header is missing",
err,
attribute.String("error.message", a.ErrorMessage),
)
if !errors.Is(err, ErrNoAuthHeader) {
telemetry.ReportError(ctx,
"authorization header is missing",
Copy link
Copy Markdown

@cursor cursor Bot May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Telemetry message misleading after conditional skip

Low Severity

The telemetry.ReportError message "authorization header is missing" now only fires for ErrInvalidAuthHeader (malformed header), since ErrNoAuthHeader is explicitly excluded by the new guard. The telemetry event description no longer matches the actual error condition — it will misleadingly report "missing" when the header was present but malformed.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 1c01dff. Configure here.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The telemetry message "authorization header is missing" is incorrect because the preceding check ensures the error is not ErrNoAuthHeader. The message should be updated to "authorization header is invalid" to correctly reflect the state when ErrInvalidAuthHeader is returned.

Suggested change
"authorization header is missing",
"authorization header is invalid",

err,
attribute.String("error.message", a.ErrorMessage),
)
}

ginCtx.Status(http.StatusUnauthorized)

Expand Down
Loading