Skip to content

fix: align client-proxy HEALTH_PORT default to 3001 #3156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AdaAibaby wants to merge 3 commits into
base: main
Choose a base branch
from
+4 −4
Open

fix: align client-proxy HEALTH_PORT default to 3001 #3156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81929cc
fix: align client-proxy HEALTH_PORT default to 3001
adababys Jul 1, 2026
f982e1c
test: update TestParse_Defaults to expect health port 3001
adababys Jul 1, 2026
a19e691
fix: update hardcoded health port 3003 references to 3001
adababys Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/start-services/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,5 +157,5 @@ runs:
STARTUP_TIMEOUT=60 ./scripts/start-service.sh "API" packages/api run ~/logs/api.log http://localhost:3000/health

# Start client-proxy (needed for auto-resume tests)
./scripts/start-service.sh "ClientProxy" packages/client-proxy run ~/logs/client-proxy.log http://localhost:3003
./scripts/start-service.sh "ClientProxy" packages/client-proxy run ~/logs/client-proxy.log http://localhost:3001
shell: bash
2 changes: 1 addition & 1 deletion DEV-LOCAL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ These commands launch each service in the foreground. You need multiple terminal
```bash
make -C packages/client-proxy run-local
```
Verify: `curl -s http://localhost:3003/health` returns a response.
Verify: `curl -s http://localhost:3001/health` returns a response.

## Build the base template

Expand Down
2 changes: 1 addition & 1 deletion packages/client-proxy/internal/cfg/model.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ package cfg
import "github.com/caarlos0/env/v11"

type Config struct {
HealthPort uint16 `env:"HEALTH_PORT" envDefault:"3003"`
HealthPort uint16 `env:"HEALTH_PORT" envDefault:"3001"`
Comment thread
AdaAibaby marked this conversation as resolved.
Comment thread
AdaAibaby marked this conversation as resolved.
ProxyPort uint16 `env:"PROXY_PORT" envDefault:"3002"`

RedisURL string `env:"REDIS_URL"`
Expand Down
2 changes: 1 addition & 1 deletion packages/client-proxy/internal/cfg/model_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ func TestParse_Defaults(t *testing.T) {

cfg, err := Parse()
require.NoError(t, err)
require.EqualValues(t, 3003, cfg.HealthPort)
require.EqualValues(t, 3001, cfg.HealthPort)
require.EqualValues(t, 3002, cfg.ProxyPort)
require.Equal(t, 40, cfg.RedisPoolSize)
require.Empty(t, cfg.RedisURL)
Expand Down