Skip to content

chore(envd): document intentional context-propagation nolints #3198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
morningtzh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(envd): document intentional context-propagation nolints #3198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/envd/internal/api/init.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ func (a *API) PostInit(w http.ResponseWriter, r *http.Request) {
}
}

go func() { //nolint:contextcheck // TODO: fix this later
go func() { //nolint:contextcheck // MMDS re-poll must outlive the /init HTTP response, so it can't derive from r.Context
ctx, cancel := context.WithTimeout(context.Background(), 60*time.Second)
defer cancel()
host.PollForMMDSOpts(ctx, a.mmdsChan, a.defaults.EnvVars)
Expand Down
2 changes: 1 addition & 1 deletion packages/envd/internal/services/process/start.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ func (s *Service) handleStart(ctx context.Context, req *connect.Request[rpc.Star
procCtx, cancelProc = context.WithTimeout(procCtx, requestTimeout)
}

proc, err := handler.New( //nolint:contextcheck // TODO: fix this later
proc, err := handler.New( //nolint:contextcheck // procCtx is intentionally decoupled from the request ctx so the process outlives the RPC (see comment above)
procCtx,
u,
req.Msg,
Expand Down