Add optional depth parameter to envd's ListDir #524
Merged
Conversation
…istDir service method
11 tasks
mishushakov
approved these changes
Apr 1, 2025
Contributor
Author
oh wow really ? where did you see this? |
Member
|
Member
it reads stores names of the files / directories, which should be fine |
Member
|
@mishushakov Can you merge if everything looks ok to you from both technical and DX perspective? |
…e-files-list-in-the-sdk-e2b-1902
mishushakov
requested changes
Apr 14, 2025
mishushakov
requested changes
Apr 15, 2025
Member
mishushakov
left a comment
There was a problem hiding this comment.
Make tests explicit and the rest looks good
…e-files-list-in-the-sdk-e2b-1902
mishushakov
approved these changes
Apr 16, 2025
0div
added a commit
to e2b-dev/E2B
that referenced
this pull request
May 5, 2025
# Description Do not merge before e2b-dev/infra#524 is merged and deployed. The DX would look like this: ```js const files = await sandbox.files.list(dirName, { depth: 3 }) ``` - [x] update `envd` pb spec - [x] generate for `js-sdk` - [x] update `js-sdk` `file.list` method to include optional depth param - [x] update `js-sdk` tests - [x] generate for `python-sdk` - [x] update `python-sdk` `file.list` method to include optional depth param - [x] sync - [x] async - [x] update `python-sdk` tests - [x] sync - [x] async --------- Co-authored-by: Mish <10400064+mishushakov@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This
envdchange allows us to add an optionaldepthparameter tofiles.listmethod on the SDK.The DX on the SDK side would look like this:
Test