forked from openSUSE/openSUSE-release-tools
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathcheck_source_in_factory.py
More file actions
executable file
·174 lines (146 loc) · 7.48 KB
/
check_source_in_factory.py
File metadata and controls
executable file
·174 lines (146 loc) · 7.48 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
#!/usr/bin/python3
from pprint import pprint
import os
import sys
import re
import logging
from optparse import OptionParser
import cmdln
try:
from xml.etree import cElementTree as ET
except ImportError:
import cElementTree as ET
import osc.conf
import osc.core
from urllib.error import HTTPError, URLError
import yaml
import ReviewBot
class FactorySourceChecker(ReviewBot.ReviewBot):
""" this review bot checks if the sources of a submission are
either in Factory or a request for Factory with the same sources
exist. If the latter a request is only accepted if the Factory
request is reviewed positive."""
def __init__(self, *args, **kwargs):
ReviewBot.ReviewBot.__init__(self, *args, **kwargs)
self.factory = [ "openSUSE:Factory" ]
self.review_messages = { 'accepted': 'ok', 'declined': 'the package needs to be accepted in Factory first' }
self.history_limit = 5
def check_source_submission(self, src_project, src_package, src_rev, target_project, target_package):
super(FactorySourceChecker, self).check_source_submission(src_project, src_package, src_rev, target_project, target_package)
src_srcinfo = self.get_sourceinfo(src_project, src_package, src_rev)
if src_srcinfo is None:
# source package does not exist?
# handle here to avoid crashing on the next line
self.logger.info("Could not get source info for %s/%s@%s" % (src_project, src_package, src_rev))
return False
projects = self._package_get_upstream_projects(target_package)
if projects is None:
self.logger.error("no upstream project found for {}, can't check".format(target_package))
return False
self.review_messages['declined'] = 'the package needs to be accepted in {} first'.format(' or '.join(projects))
for project in projects:
self.logger.info("Checking in project %s" % project)
good = self._check_matching_srcmd5(project, target_package, src_srcinfo.verifymd5, self.history_limit)
if good:
self.logger.info("{} is in {}".format(target_package, project))
return good
good = self._check_requests(project, target_package, src_srcinfo.verifymd5)
if good:
self.logger.info("{} already reviewed for {}".format(target_package, project))
if not good:
self.logger.info('{} failed source submission check'.format(target_package))
return good
def _package_get_upstream_projects(self, package):
""" return list of projects where the specified package is supposed to come
from. Either by lookup table or self.factory """
projects = []
for prj in self.factory:
r = self.lookup.get(prj, package)
if r:
projects.append(r)
if not projects:
projects = self.factory
return projects
def _check_requests(self, project, package, rev):
self.logger.debug("checking requests")
prjprefix = ''
apiurl = self.apiurl
sr = 'sr'
try:
if self.config.project_namespace_api_map:
for prefix, url, srprefix in self.config.project_namespace_api_map:
if project.startswith(prefix):
apiurl = url
prjprefix = prefix
project = project[len(prefix):]
sr = srprefix
break
requests = osc.core.get_request_list(apiurl, project, package, None, ['new', 'review'], 'submit')
except (HTTPError, URLError):
self.logger.error("caught exception while checking %s/%s", project, package)
return None
def srref(reqid):
return '#'.join((sr, reqid))
for req in requests:
for a in req.actions:
si = self.get_sourceinfo(prjprefix + a.src_project, a.src_package, a.src_rev)
self.logger.debug("rq %s: %s/%s@%s" % (req.reqid, prjprefix + a.src_project, a.src_package, si.verifymd5))
if si.verifymd5 == rev:
if req.state.name == 'new':
self.logger.info("%s ok", srref(req.reqid))
return True
elif req.state.name == 'review':
self.logger.debug("%s still in review", srref(req.reqid))
if not req.reviews:
self.logger.error("%s in state review but no reviews?", srref(req.reqid))
return False
for r in req.reviews:
if r.state == 'new':
if r.by_project and r.by_project.startswith('openSUSE:Factory:Staging:'):
self.logger.info("%s review by %s ok", srref(req.reqid), r.by_project)
continue
if r.by_user == 'repo-checker':
self.logger.info('%s review by %s ok', srref(req.reqid), r.by_user)
continue
if r.state != 'accepted':
if r.by_user:
self.logger.info("%s waiting for review by %s", srref(req.reqid), r.by_user)
elif r.by_group:
self.logger.info("%s waiting for review by %s", srref(req.reqid), r.by_group)
elif r.by_project:
if r.by_package:
self.logger.info("%s waiting for review by %s/%s", srref(req.reqid), r.by_project, r.by_package)
else:
self.logger.info("%s waiting for review by %s", srref(req.reqid), r.by_project)
return None
return True
else:
self.logger.error("%s in state %s not expected", srref(req.reqid), req.state.name)
return None
else:
self.logger.info("%s to %s has different sources", srref(req.reqid), project)
return False
class CommandLineInterface(ReviewBot.CommandLineInterface):
def __init__(self, *args, **kwargs):
ReviewBot.CommandLineInterface.__init__(self, args, kwargs)
self.clazz = FactorySourceChecker
def get_optparser(self):
parser = ReviewBot.CommandLineInterface.get_optparser(self)
parser.add_option("--factory", metavar="project", action="append",
help=("Project to check source against. Use multiple times to check more than one project. "
"[default: openSUSE:Factory]"))
parser.add_option("--lookup", metavar="project", help="use lookup file")
parser.add_option("--limit", metavar="limit", help="how many revisions back to check. [default: 5]")
return parser
def setup_checker(self):
bot = ReviewBot.CommandLineInterface.setup_checker(self)
if self.options.factory:
bot.factory = self.options.factory
if self.options.lookup:
bot.parse_lookup(self.options.lookup)
if self.options.limit:
bot.history_limit = self.options.limit
return bot
if __name__ == "__main__":
app = CommandLineInterface()
sys.exit( app.main() )