Skip to content

Fix one index with multiple topic urls#68

Merged
u-235 merged 2 commits into
eBookProjects:masterfrom
gonwan:fix-index
Jan 22, 2026
Merged

Fix one index with multiple topic urls#68
u-235 merged 2 commits into
eBookProjects:masterfrom
gonwan:fix-index

Conversation

@gonwan

@gonwan gonwan commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

Use attachment for testing.

Some chm files have one index name links to multiple topics. Just align behavior with hh.exe.

Urls with CJK characters work fine.
In addition, index are now sorted, and the index tree widget scrolls to the matching item to top when searching.

testindex.zip

@gonwan

gonwan commented Jan 21, 2026

Copy link
Copy Markdown
Contributor Author

With second commit, internal files are ensured to use internal encoding. The attachment is a chm file with gbk internal encoding and utf-8 text encoding. Select Chinese Simplified (UTF-8/GBK) to view.
The index tab is also refreshed when changing encoding.

testencoding.zip

@u-235

u-235 commented Jan 21, 2026

Copy link
Copy Markdown
Member

I think the src/dialog_topicselector.ui file was accidentally included in the PR; the only significant change in it is the line <?xml version="1.0" encoding="UTF-8"?>. And one more thing: it would be nice to add an empty line before the ParsedEntry::clear function.

@gonwan

gonwan commented Jan 22, 2026

Copy link
Copy Markdown
Contributor Author

I think the src/dialog_topicselector.ui file was accidentally included in the PR; the only significant change in it is the line <?xml version="1.0" encoding="UTF-8"?>.

Other *.ui files have this line. A newly created one also has this line. I also deleted some redundant space, and make the dialog wider, since some index titles are so long. I think the file was modified incorrectly by some misconfigured tools.

@u-235 u-235 merged commit 045a743 into eBookProjects:master Jan 22, 2026
10 checks passed
@gonwan gonwan deleted the fix-index branch January 22, 2026 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants