Check data is taken in RpcBridge::transmit_ (#142)

Tomoya Fujita · web-flow · commit 4e76d6761048 · 2025-03-28T09:01:46.000+01:00
Signed-off-by: Tomoya.Fujita &lt;tomoya.fujita825@gmail.com&gt;
diff --git a/ddspipe_core/src/cpp/communication/rpc/RpcBridge.cpp b/ddspipe_core/src/cpp/communication/rpc/RpcBridge.cpp
@@ -297,9 +297,6 @@ void RpcBridge::transmit_(
         std::unique_ptr<IRoutingData> data;
         utils::ReturnCode ret = reader->take(data);
 
-        RpcPayloadData& rpc_data = dynamic_cast<RpcPayloadData&>(*data);
-
-
         // Will never return \c NO_DATA, otherwise would have finished before
         if (ret != utils::ReturnCode::RETCODE_OK)
         {
@@ -311,6 +308,8 @@ void RpcBridge::transmit_(
             continue;
         }
 
+        RpcPayloadData& rpc_data = dynamic_cast<RpcPayloadData&>(*data);
+
         if (RpcTopic::is_request_topic(reader->topic()))
         {
             logDebug(DDSPIPE_RPCBRIDGE,

Original file line number	Diff line number	Diff line change
`@@ -297,9 +297,6 @@ void RpcBridge::transmit_(`
`297`	`297`	`std::unique_ptr<IRoutingData> data;`
`298`	`298`	`utils::ReturnCode ret = reader->take(data);`
`299`	`299`
`300`		`- RpcPayloadData& rpc_data = dynamic_cast<RpcPayloadData&>(*data);`
`301`		`-`
`302`		`-`
`303`	`300`	`// Will never return \c NO_DATA, otherwise would have finished before`
`304`	`301`	`if (ret != utils::ReturnCode::RETCODE_OK)`
`305`	`302`	`{`
`@@ -311,6 +308,8 @@ void RpcBridge::transmit_(`
`311`	`308`	`continue;`
`312`	`309`	`}`
`313`	`310`
	`311`	`+ RpcPayloadData& rpc_data = dynamic_cast<RpcPayloadData&>(*data);`
	`312`	`+`
`314`	`313`	`if (RpcTopic::is_request_topic(reader->topic()))`
`315`	`314`	`{`
`316`	`315`	`logDebug(DDSPIPE_RPCBRIDGE,`