Skip to content

Commit 94b581e

Browse files
Update branches in .repos (#477)
* Update branches in .repos Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> * BONUS: remove deprecated log macros Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com> --------- Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
1 parent abde2e1 commit 94b581e

7 files changed

Lines changed: 29 additions & 27 deletions

File tree

ddsrouter.repos

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,15 @@ repositories:
1010
fastdds:
1111
type: git
1212
url: https://github.com/eProsima/Fast-DDS.git
13-
version: 2.x
13+
version: 3.x
1414
dev-utils:
1515
type: git
1616
url: https://github.com/eProsima/dev-utils.git
17-
version: 0.x
17+
version: 1.x
1818
ddspipe:
1919
type: git
2020
url: https://github.com/eProsima/DDS-Pipe.git
21-
version: main
21+
version: 1.x
2222
ddsrouter:
2323
type: git
2424
url: https://github.com/eProsima/DDS-Router.git

ddsrouter_core/src/cpp/configuration/SpecsConfiguration.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,8 @@ bool SpecsConfiguration::is_valid(
3737

3838
if (topic_qos.history_depth == 0U)
3939
{
40-
logWarning(DDSROUTER_SPECS, "Using non limited histories could lead to memory exhaustion in long executions.");
40+
EPROSIMA_LOG_WARNING(DDSROUTER_SPECS,
41+
"Using non limited histories could lead to memory exhaustion in long executions.");
4142
}
4243

4344
return true;

ddsrouter_core/src/cpp/core/DdsRouter.cpp

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -87,8 +87,9 @@ void DdsRouter::init_participants_()
8787
<< "Failed to create creating Participant " << participant_config.second->id);
8888
}
8989

90-
logInfo(DDSROUTER, "Participant created with id: " << new_participant->id()
91-
<< " and kind " << participant_config.first << ".");
90+
EPROSIMA_LOG_INFO(DDSROUTER, "Participant created with id: " << new_participant->id()
91+
<< " and kind " << participant_config.first <<
92+
".");
9293

9394
// Add this participant to the database. If it is repeated it will cause an exception
9495
try
@@ -126,7 +127,7 @@ utils::ReturnCode DdsRouter::start() noexcept
126127
utils::ReturnCode ret = ddspipe_->enable();
127128
if (ret == utils::ReturnCode::RETCODE_OK)
128129
{
129-
logInfo(DDSROUTER, "Starting DDS Router.");
130+
EPROSIMA_LOG_INFO(DDSROUTER, "Starting DDS Router.");
130131
}
131132

132133
return ret;
@@ -137,7 +138,7 @@ utils::ReturnCode DdsRouter::stop() noexcept
137138
utils::ReturnCode ret = ddspipe_->disable();
138139
if (ret == utils::ReturnCode::RETCODE_OK)
139140
{
140-
logInfo(DDSROUTER, "Stopping DDS Router.");
141+
EPROSIMA_LOG_INFO(DDSROUTER, "Stopping DDS Router.");
141142
}
142143

143144
return ret;

ddsrouter_yaml/src/cpp/YamlReaderConfiguration.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ YamlReaderConfiguration::load_ddsrouter_configuration(
5858
break;
5959

6060
case ddspipe::yaml::YamlReaderVersion::V_4_0:
61-
logWarning(DDSROUTER_YAML,
61+
EPROSIMA_LOG_WARNING(DDSROUTER_YAML,
6262
"The yaml configuration version " << version <<
6363
" is deprecated and will be removed in a future release. Please update to v5.0.");
6464
break;
@@ -68,13 +68,13 @@ YamlReaderConfiguration::load_ddsrouter_configuration(
6868
{
6969
// Get default version
7070
version = default_yaml_version();
71-
logWarning(DDSROUTER_YAML,
71+
EPROSIMA_LOG_WARNING(DDSROUTER_YAML,
7272
"No version of yaml configuration given. Using version " << version << " by default. " <<
7373
"Add " << ddspipe::yaml::VERSION_TAG << " tag to your configuration in order to not break compatibility " <<
7474
"in future releases.");
7575
}
7676

77-
logInfo(DDSROUTER_YAML, "Loading DDSRouter configuration with version: " << version << ".");
77+
EPROSIMA_LOG_INFO(DDSROUTER_YAML, "Loading DDSRouter configuration with version: " << version << ".");
7878

7979
// Load DDS Router Configuration
8080
core::DdsRouterConfiguration router_configuration =

ddsrouter_yaml/src/cpp/YamlReader_configuration.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ YamlReader::get<std::shared_ptr<participants::ParticipantConfiguration>>(
116116
PARTICIPANT_KIND_TAG,
117117
version);
118118

119-
logInfo(DDSROUTER_YAML_CONFIGURATION, "Loading Participant of kind " << kind << ".");
119+
EPROSIMA_LOG_INFO(DDSROUTER_YAML_CONFIGURATION, "Loading Participant of kind " << kind << ".");
120120

121121
switch (kind)
122122
{

tools/ddsrouter_tool/src/cpp/main.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ int main(
8484
// NOTE: this check is redundant with option parse arg check
8585
if (!is_file_accessible(commandline_args.file_path.c_str(), eprosima::utils::FileAccessMode::read))
8686
{
87-
logError(
87+
EPROSIMA_LOG_ERROR(
8888
DDSROUTER_ARGS,
8989
"File '" << commandline_args.file_path << "' does not exist or it is not accessible.");
9090
return static_cast<int>(ui::ProcessReturnCode::required_argument_failed);
@@ -185,7 +185,7 @@ int main(
185185
}
186186
catch (const std::exception& e)
187187
{
188-
logWarning(DDSROUTER_EXECUTION,
188+
EPROSIMA_LOG_WARNING(DDSROUTER_EXECUTION,
189189
"Error reloading configuration file " << file_name << " with error: " << e.what());
190190
}
191191
};
@@ -223,7 +223,7 @@ int main(
223223
}
224224
catch (const std::exception& e)
225225
{
226-
logWarning(DDSROUTER_EXECUTION,
226+
EPROSIMA_LOG_WARNING(DDSROUTER_EXECUTION,
227227
"Error reloading configuration file " << commandline_args.file_path << " with error: " <<
228228
e.what());
229229
}
@@ -270,15 +270,15 @@ int main(
270270
}
271271
catch (const eprosima::utils::ConfigurationException& e)
272272
{
273-
logError(DDSROUTER_ERROR,
273+
EPROSIMA_LOG_ERROR(DDSROUTER_ERROR,
274274
"Error Loading DDS Router Configuration from file " << commandline_args.file_path <<
275275
". Error message:\n " <<
276276
e.what());
277277
return static_cast<int>(ui::ProcessReturnCode::execution_failed);
278278
}
279279
catch (const eprosima::utils::InitializationException& e)
280280
{
281-
logError(DDSROUTER_ERROR,
281+
EPROSIMA_LOG_ERROR(DDSROUTER_ERROR,
282282
"Error Initializing DDS Router. Error message:\n " <<
283283
e.what());
284284
return static_cast<int>(ui::ProcessReturnCode::execution_failed);

tools/ddsrouter_tool/src/cpp/user_interface/arguments_configuration.cpp

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ ProcessReturnCode parse_arguments(
213213
// Unknown args provided
214214
if (parse.nonOptionsCount())
215215
{
216-
logError(DDSROUTER_ARGS, "ERROR: Unknown argument: <" << parse.nonOption(0) << ">." );
216+
EPROSIMA_LOG_ERROR(DDSROUTER_ARGS, "ERROR: Unknown argument: <" << parse.nonOption(0) << ">." );
217217
option::printUsage(fwrite, stdout, usage, columns);
218218
return ProcessReturnCode::incorrect_argument;
219219
}
@@ -267,7 +267,7 @@ ProcessReturnCode parse_arguments(
267267
break;
268268

269269
case optionIndex::UNKNOWN_OPT:
270-
logError(DDSROUTER_ARGS, opt << " is not a valid argument.");
270+
EPROSIMA_LOG_ERROR(DDSROUTER_ARGS, opt << " is not a valid argument.");
271271
option::printUsage(fwrite, stdout, usage, columns);
272272
return ProcessReturnCode::incorrect_argument;
273273
break;
@@ -292,7 +292,7 @@ option::ArgStatus Arg::Unknown(
292292
{
293293
if (msg)
294294
{
295-
logError(
295+
EPROSIMA_LOG_ERROR(
296296
DDSROUTER_ARGS,
297297
"Unknown option '" << option << "'. Use -h to see this executable possible arguments.");
298298
}
@@ -310,7 +310,7 @@ option::ArgStatus Arg::Required(
310310

311311
if (msg)
312312
{
313-
logError(DDSROUTER_ARGS, "Option '" << option << "' required.");
313+
EPROSIMA_LOG_ERROR(DDSROUTER_ARGS, "Option '" << option << "' required.");
314314
}
315315
return option::ARG_ILLEGAL;
316316
}
@@ -330,7 +330,7 @@ option::ArgStatus Arg::Numeric(
330330

331331
if (msg)
332332
{
333-
logError(DDSROUTER_ARGS, "Option '" << option << "' requires a numeric argument.");
333+
EPROSIMA_LOG_ERROR(DDSROUTER_ARGS, "Option '" << option << "' requires a numeric argument.");
334334
}
335335
return option::ARG_ILLEGAL;
336336
}
@@ -350,7 +350,7 @@ option::ArgStatus Arg::Float(
350350

351351
if (msg)
352352
{
353-
logError(DDSROUTER_ARGS, "Option '" << option << "' requires a float argument.");
353+
EPROSIMA_LOG_ERROR(DDSROUTER_ARGS, "Option '" << option << "' requires a float argument.");
354354
}
355355
return option::ARG_ILLEGAL;
356356
}
@@ -365,7 +365,7 @@ option::ArgStatus Arg::String(
365365
}
366366
if (msg)
367367
{
368-
logError(DDSROUTER_ARGS, "Option '" << option << "' requires a text argument.");
368+
EPROSIMA_LOG_ERROR(DDSROUTER_ARGS, "Option '" << option << "' requires a text argument.");
369369
}
370370
return option::ARG_ILLEGAL;
371371
}
@@ -384,7 +384,7 @@ option::ArgStatus Arg::Readable_File(
384384
}
385385
if (msg)
386386
{
387-
logError(DDSROUTER_ARGS, "Option '" << option << "' requires an existing readable file as argument.");
387+
EPROSIMA_LOG_ERROR(DDSROUTER_ARGS, "Option '" << option << "' requires an existing readable file as argument.");
388388
}
389389
return option::ARG_ILLEGAL;
390390
}
@@ -405,7 +405,7 @@ option::ArgStatus Arg::Valid_Options(
405405
{
406406
if (msg)
407407
{
408-
logError(DDSROUTER_ARGS, "Option '" << option.name << "' requires a text argument.");
408+
EPROSIMA_LOG_ERROR(DDSROUTER_ARGS, "Option '" << option.name << "' requires a text argument.");
409409
}
410410
return option::ARG_ILLEGAL;
411411
}
@@ -424,7 +424,7 @@ option::ArgStatus Arg::Valid_Options(
424424
}
425425
error_msg << "}.";
426426

427-
logError(DDSROUTER_ARGS, error_msg);
427+
EPROSIMA_LOG_ERROR(DDSROUTER_ARGS, error_msg);
428428
}
429429

430430
return option::ARG_ILLEGAL;

0 commit comments

Comments
 (0)