[23573] Add blackbox tests for original writer info in ddspipe#525
Merged
Conversation
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
emiliocuestaf
had a problem deploying
to
codecov
August 25, 2025 12:18 — with
GitHub Actions
Failure
cferreiragonz
requested changes
Aug 27, 2025
cferreiragonz
left a comment
Contributor
There was a problem hiding this comment.
Maybe we can swap case 2 and case 3. In this way the expected value on the subscriber side will change between the three tested cases. Right now, case 1 and case 2 will generate the same value and it might occur that the value is not updated but the test does not report it.
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
emiliocuestaf
had a problem deploying
to
codecov
August 28, 2025 07:46 — with
GitHub Actions
Failure
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
emiliocuestaf
had a problem deploying
to
codecov
August 28, 2025 07:50 — with
GitHub Actions
Failure
cferreiragonz
previously approved these changes
Aug 28, 2025
cferreiragonz
left a comment
Contributor
There was a problem hiding this comment.
LGTM with green CI
emiliocuestaf
had a problem deploying
to
codecov
September 1, 2025 06:08 — with
GitHub Actions
Error
emiliocuestaf
had a problem deploying
to
codecov
September 1, 2025 07:30 — with
GitHub Actions
Failure
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
emiliocuestaf
had a problem deploying
to
codecov
September 1, 2025 09:01 — with
GitHub Actions
Failure
emiliocuestaf
temporarily deployed
to
codecov
September 1, 2025 15:08 — with
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #525 +/- ##
==========================================
- Coverage 31.14% 30.24% -0.90%
==========================================
Files 16 16
Lines 594 562 -32
Branches 321 298 -23
==========================================
- Hits 185 170 -15
+ Misses 213 205 -8
+ Partials 196 187 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
emiliocuestaf
temporarily deployed
to
codecov
September 2, 2025 10:31 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a blackbox test that checks that:
This PR depends on eProsima/DDS-Pipe#163 and must be merged after it.