Skip to content

Fix test 13 - #118

Merged
cferreiragonz merged 1 commit into
1.2.xfrom
fix_test_13
Jul 22, 2025
Merged

Fix test 13#118
cferreiragonz merged 1 commit into
1.2.xfrom
fix_test_13

Conversation

@cferreiragonz

@cferreiragonz cferreiragonz commented Jul 22, 2025

Copy link
Copy Markdown
Contributor

Description

This PR fixes test 13 of discovery server by correctly setting the timestamp of snapshot test_13_disposals_single_server_a.P1_-_b.S1. For some reason, this snapshot was not reflecting the test chronology described at the beginning of the test case. This was corrected during the Discovery Server refactor in master, but it was never backported. The test started failing after eProsima/Fast-DDS#5556.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The added tests pass locally.
  • N/A Changes are backwards compatible.
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
@cferreiragonz
cferreiragonz changed the base branch from master to 1.2.x July 22, 2025 10:49
@cferreiragonz
cferreiragonz removed the request for review from richiprosima July 22, 2025 10:50
@MiguelCompany MiguelCompany added this to the v1.2.3 milestone Jul 22, 2025

@MiguelCompany MiguelCompany left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cferreiragonz
cferreiragonz merged commit 9d3b09e into 1.2.x Jul 22, 2025
4 checks passed
@cferreiragonz
cferreiragonz deleted the fix_test_13 branch July 22, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants