Skip to content

[21128] Update guards and extenstion .h to .hpp in headers - #358

Merged
EduPonz merged 3 commits into
masterfrom
feature/21128
Jun 27, 2024
Merged

[21128] Update guards and extenstion .h to .hpp in headers#358
EduPonz merged 3 commits into
masterfrom
feature/21128

Conversation

@JesusPoderoso

@JesusPoderoso JesusPoderoso commented Jun 18, 2024 •
edited by EduPonz
Loading

Copy link
Copy Markdown
Contributor

Description

This PR is the FastDDS Gen counterpart of this FastDDS PR:

This is part of the set of PRs preparing the new major version 3.x in FastDDS. Consequently, it cannot be backported

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso JesusPoderoso added this to the v4.0.0 milestone Jun 18, 2024
@JesusPoderoso
JesusPoderoso requested a review from EduPonz June 18, 2024 13:13
@JesusPoderoso JesusPoderoso self-assigned this Jun 18, 2024
@JesusPoderoso
JesusPoderoso force-pushed the feature/21128 branch 3 times, most recently from 015658f to 75dffe3 Compare June 18, 2024 14:10
@JesusPoderoso JesusPoderoso mentioned this pull request Jun 21, 2024
Merged
8 tasks
EduPonz
EduPonz suggested changes Jun 26, 2024
View reviewed changes

@EduPonz EduPonz left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing include guards update in src/main/java/com/eprosima/fastcdr/idl/templates/TypesHeader.stg

@JesusPoderoso
JesusPoderoso requested a review from EduPonz June 26, 2024 09:53
EduPonz
EduPonz previously approved these changes Jun 26, 2024
View reviewed changes
@JesusPoderoso
Refs #21128: Update guards and .h to .hpp
80a668a 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso
Refs #21128: Fix uncrustify
86c928f 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso
Refs #21128: Apply rev suggestion
dbc1702 
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
@JesusPoderoso
JesusPoderoso requested a review from EduPonz June 26, 2024 13:04
@EduPonz
EduPonz merged commit b1f21c3 into master Jun 27, 2024
@EduPonz
EduPonz deleted the feature/21128 branch June 27, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@EduPonz EduPonz EduPonz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@JesusPoderoso JesusPoderoso

Labels

None yet

Projects

None yet

Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@JesusPoderoso @EduPonz